src: Remove __DATE__ from internal error messages.

The date didn't really add much information (it is the day on which the
code happened to be compiled) and it prevents creating reproducible builds.

Signed-off-by: Mark Wielaard <mjw@redhat.com>

diff --git a/src/ChangeLog b/src/ChangeLog
index 858d0f7a22ce81d289fcf120484352a25ddbebdf..c8ddff69757222b2e1e53c50d74357dce78ef937 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,10 @@
+2015-03-14  Mark Wielaard  <mjw@redhat.com>
+
+       * nm.c (INTERNAL_ERROR): Remove __DATE__.
+       * objdump.c (INTERNAL_ERROR): Likewise.
+       * size.c (INTERNAL_ERROR): Likewise.
+       * strip.c (INTERNAL_ERROR): Likewise.
+
 2015-03-18  Petr Machata  <pmachata@redhat.com>
 
        * readelf.c (dwarf_tag_string, dwarf_attr_string)

diff --git a/src/nm.c b/src/nm.c
index 915153fa2f2ed23cc2c7ee89f2757100790ab8ea..67fb4c295211ea3c1edbec6ade165ea21775a78f 100644 (file)
--- a/src/nm.c
+++ b/src/nm.c
@@ -1,5 +1,5 @@
 /* Print symbol information from ELF file in human-readable form.
-   Copyright (C) 2000-2008, 2009, 2011, 2012, 2014 Red Hat, Inc.
+   Copyright (C) 2000-2008, 2009, 2011, 2012, 2014, 2015 Red Hat, Inc.
    This file is part of elfutils.
    Written by Ulrich Drepper <drepper@redhat.com>, 2000.
 
@@ -137,8 +137,8 @@ static int handle_elf (Elf *elf, const char *prefix, const char *fname,
 
 
 #define INTERNAL_ERROR(fname) \
-  error (EXIT_FAILURE, 0, gettext ("%s: INTERNAL ERROR %d (%s-%s): %s"),      \
-        fname, __LINE__, PACKAGE_VERSION, __DATE__, elf_errmsg (-1))
+  error (EXIT_FAILURE, 0, gettext ("%s: INTERNAL ERROR %d (%s): %s"),      \
+        fname, __LINE__, PACKAGE_VERSION, elf_errmsg (-1))
 
 
 /* Internal representation of symbols.  */

diff --git a/src/objdump.c b/src/objdump.c
index 87290ccbf1a17c9c3997802f24afc8eed300d1ff..b689024b76cb145748e1ef7afbbc81708662c8e7 100644 (file)
--- a/src/objdump.c
+++ b/src/objdump.c
@@ -1,5 +1,5 @@
 /* Print information from ELF file in human-readable form.
-   Copyright (C) 2005, 2006, 2007, 2009, 2011, 2012, 2014 Red Hat, Inc.
+   Copyright (C) 2005, 2006, 2007, 2009, 2011, 2012, 2014, 2015 Red Hat, Inc.
    This file is part of elfutils.
    Written by Ulrich Drepper <drepper@redhat.com>, 2005.
 
@@ -101,8 +101,8 @@ static int handle_elf (Elf *elf, const char *prefix, const char *fname,
 
 
 #define INTERNAL_ERROR(fname) \
-  error (EXIT_FAILURE, 0, gettext ("%s: INTERNAL ERROR %d (%s-%s): %s"),      \
-        fname, __LINE__, PACKAGE_VERSION, __DATE__, elf_errmsg (-1))
+  error (EXIT_FAILURE, 0, gettext ("%s: INTERNAL ERROR %d (%s): %s"),      \
+        fname, __LINE__, PACKAGE_VERSION, elf_errmsg (-1))
 
 
 /* List of sections which should be used.  */

diff --git a/src/size.c b/src/size.c
index 0e7e41e490a14311383d201faabfcffd6d4d76d6..0ec1139bc16e19d7ce3cd41b1bcf70c6e4f05de1 100644 (file)
--- a/src/size.c
+++ b/src/size.c
@@ -1,5 +1,5 @@
 /* Print size information from ELF file.
-   Copyright (C) 2000-2007,2009,2012,2014 Red Hat, Inc.
+   Copyright (C) 2000-2007,2009,2012,2014,2015 Red Hat, Inc.
    This file is part of elfutils.
    Written by Ulrich Drepper <drepper@redhat.com>, 2000.
 
@@ -106,8 +106,8 @@ static void handle_elf (Elf *elf, const char *fullname, const char *fname);
 static void show_bsd_totals (void);
 
 #define INTERNAL_ERROR(fname) \
-  error (EXIT_FAILURE, 0, gettext ("%s: INTERNAL ERROR %d (%s-%s): %s"),      \
-        fname, __LINE__, PACKAGE_VERSION, __DATE__, elf_errmsg (-1))
+  error (EXIT_FAILURE, 0, gettext ("%s: INTERNAL ERROR %d (%s): %s"),      \
+        fname, __LINE__, PACKAGE_VERSION, elf_errmsg (-1))
 
 
 /* User-selectable options.  */

diff --git a/src/strip.c b/src/strip.c
index 2b2179969e2b5f3ddda538c4f2ecf9c31a751ad0..c003647a1afb447b50171c0fee626ba4824f65da 100644 (file)
--- a/src/strip.c
+++ b/src/strip.c
@@ -1,5 +1,5 @@
 /* Discard section not used at runtime from object files.
-   Copyright (C) 2000-2012, 2014 Red Hat, Inc.
+   Copyright (C) 2000-2012, 2014, 2015 Red Hat, Inc.
    This file is part of elfutils.
    Written by Ulrich Drepper <drepper@redhat.com>, 2000.
 
@@ -117,8 +117,8 @@ static int handle_ar (int fd, Elf *elf, const char *prefix, const char *fname,
                      struct timeval tvp[2]);
 
 #define INTERNAL_ERROR(fname) \
-  error (EXIT_FAILURE, 0, gettext ("%s: INTERNAL ERROR %d (%s-%s): %s"),      \
-        fname, __LINE__, PACKAGE_VERSION, __DATE__, elf_errmsg (-1))
+  error (EXIT_FAILURE, 0, gettext ("%s: INTERNAL ERROR %d (%s): %s"),      \
+        fname, __LINE__, PACKAGE_VERSION, elf_errmsg (-1))
 
 
 /* Name of the output file.  */