]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
Rewrite tcl_version_at_least
authorTom Tromey <tromey@adacore.com>
Fri, 25 Jul 2025 18:18:14 +0000 (12:18 -0600)
committerTom Tromey <tromey@adacore.com>
Mon, 8 Sep 2025 14:39:19 +0000 (08:39 -0600)
tcl_version_at_least can more easily be expressed using the built-in
"package" command.

Approved-By: Simon Marchi <simon.marchi@efficios.com>
gdb/testsuite/lib/gdb.exp

index 58cdd7d672c7ef82ad9497bc66322291e3fa779b..b5092c6132bb9ae093b81da80570b8452feb6403 100644 (file)
@@ -1680,21 +1680,9 @@ proc python_version_at_least { major minor } {
 
 # Return 1 if tcl version used is at least MAJOR.MINOR.PATCHLEVEL.
 proc tcl_version_at_least { major minor {patchlevel 0} } {
-    global tcl_patchLevel
-    regexp {^([0-9]+)\.([0-9]+)\.([0-9]+)$} \
-       $tcl_patchLevel dummy \
-       tcl_version_major tcl_version_minor tcl_version_patchlevel
-    return \
-       [version_compare \
-            [list \
-                 $major \
-                 $minor \
-                 $patchlevel] \
-            <= \
-            [list \
-                 $tcl_version_major \
-                 $tcl_version_minor \
-                 $tcl_version_patchlevel]]
+    set current_version [package require Tcl]
+    set min_version "$major.$minor.$patchlevel"
+    return [expr {[package vcompare $current_version $min_version] >= 0}]
 }
 
 if { [tcl_version_at_least 8 6] == 0 } {