]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib-smtp: smtp-client-connection - Properly log SSL handshake failure occuring during...
authorStephan Bosch <stephan.bosch@dovecot.fi>
Sat, 14 Jul 2018 10:19:07 +0000 (12:19 +0200)
committertimo.sirainen <timo.sirainen@open-xchange.com>
Mon, 24 Aug 2020 07:20:16 +0000 (07:20 +0000)
src/lib-smtp/smtp-client-connection.c

index 3f7d074b242f224a9885b507c85a60ce440972e0..2f85f68b85762712701c6ce4323fc37138eeb02b 100644 (file)
@@ -1085,16 +1085,14 @@ static void smtp_client_connection_input(struct connection *_conn)
                if (ret < 0) {
                        /* failed somehow */
                        i_assert(ret != -2);
-                       error = t_strdup_printf(
+                       e_error(conn->event,
                                "SSL handshaking with %s failed: "
                                "read(%s) failed: %s", _conn->name,
                                i_stream_get_name(conn->conn.input),
                                i_stream_get_error(conn->conn.input));
-                       e_debug(conn->event, "connect(%s) failed: %s",
-                               _conn->name, error);
                        smtp_client_connection_fail(
                                conn, SMTP_CLIENT_COMMAND_ERROR_CONNECT_FAILED,
-                               error);
+                               "Failed to connect to remote server");
                        return;
                }