]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/i915/vblank: fix context imbalance warnings
authorJani Nikula <jani.nikula@intel.com>
Thu, 22 Aug 2024 16:04:50 +0000 (19:04 +0300)
committerJani Nikula <jani.nikula@intel.com>
Fri, 23 Aug 2024 08:51:21 +0000 (11:51 +0300)
When building for xe, we get the context imbalance warning as the actual
locking/unlocking is not compiled:

../drivers/gpu/drm/i915/display/intel_vblank.c:306:13: warning: context imbalance in 'intel_vblank_section_enter' - wrong count at exit
../drivers/gpu/drm/i915/display/intel_vblank.c:314:13: warning: context imbalance in 'intel_vblank_section_exit' - wrong count at exit

Fix by adding separata stubs for xe without __acquires/__releases
annotation.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/111de5bee15f408de65b19ece4b68a7ac66b30cf.1724342644.git.jani.nikula@intel.com
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_vblank.c

index 551e9ca9bb99c76a23ba6f91407d1304316dfb80..2073e8075af4db57481c94648aa2cdaf4e939a59 100644 (file)
@@ -303,21 +303,27 @@ int intel_crtc_scanline_to_hw(struct intel_crtc *crtc, int scanline)
  * all register accesses to the same cacheline to be serialized,
  * otherwise they may hang.
  */
+#ifdef I915
 static void intel_vblank_section_enter(struct drm_i915_private *i915)
        __acquires(i915->uncore.lock)
 {
-#ifdef I915
        spin_lock(&i915->uncore.lock);
-#endif
 }
 
 static void intel_vblank_section_exit(struct drm_i915_private *i915)
        __releases(i915->uncore.lock)
 {
-#ifdef I915
        spin_unlock(&i915->uncore.lock);
-#endif
 }
+#else
+static void intel_vblank_section_enter(struct drm_i915_private *i915)
+{
+}
+
+static void intel_vblank_section_exit(struct drm_i915_private *i915)
+{
+}
+#endif
 
 static bool i915_get_crtc_scanoutpos(struct drm_crtc *_crtc,
                                     bool in_vblank_irq,