]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
rv: Return init error when registering monitors
authorGabriele Monaco <gmonaco@redhat.com>
Wed, 23 Jul 2025 16:12:40 +0000 (18:12 +0200)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Thu, 24 Jul 2025 14:43:46 +0000 (10:43 -0400)
Monitors generated with dot2k have their registration function (the one
called during monitor initialisation) return always 0, even if the
registration failed on RV side.
This can hide potential errors.

Return the value returned by the RV register function.

Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Tomas Glozar <tglozar@redhat.com>
Cc: Juri Lelli <jlelli@redhat.com>
Cc: Clark Williams <williams@redhat.com>
Cc: John Kacur <jkacur@redhat.com>
Link: https://lore.kernel.org/20250723161240.194860-6-gmonaco@redhat.com
Reviewed-by: Nam Cao <namcao@linutronix.de>
Signed-off-by: Gabriele Monaco <gmonaco@redhat.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/rv/monitors/sched/sched.c
kernel/trace/rv/monitors/sco/sco.c
kernel/trace/rv/monitors/scpd/scpd.c
kernel/trace/rv/monitors/sncid/sncid.c
kernel/trace/rv/monitors/snep/snep.c
kernel/trace/rv/monitors/snroc/snroc.c
kernel/trace/rv/monitors/tss/tss.c
kernel/trace/rv/monitors/wip/wip.c
kernel/trace/rv/monitors/wwnr/wwnr.c
tools/verification/rvgen/rvgen/templates/container/main.c
tools/verification/rvgen/rvgen/templates/dot2k/main.c

index 905e03c3c934d4acde769c8cff3452596fd3c182..d04db4b543f9600f0bc8fd351398f0c40161c3ba 100644 (file)
@@ -21,8 +21,7 @@ struct rv_monitor rv_sched = {
 
 static int __init register_sched(void)
 {
-       rv_register_monitor(&rv_sched, NULL);
-       return 0;
+       return rv_register_monitor(&rv_sched, NULL);
 }
 
 static void __exit unregister_sched(void)
index 4cff59220bfc79bbb99121ca8647d9bcc1e2ded6..66f4639d46ac496a8433a77fb46b7af1fef69efd 100644 (file)
@@ -71,8 +71,7 @@ static struct rv_monitor rv_sco = {
 
 static int __init register_sco(void)
 {
-       rv_register_monitor(&rv_sco, &rv_sched);
-       return 0;
+       return rv_register_monitor(&rv_sco, &rv_sched);
 }
 
 static void __exit unregister_sco(void)
index cbdd6a5f8d7fdbbf086642cd00e876965c264897..299703cd72b06f4194e546f848d2ec0e7882979f 100644 (file)
@@ -79,8 +79,7 @@ static struct rv_monitor rv_scpd = {
 
 static int __init register_scpd(void)
 {
-       rv_register_monitor(&rv_scpd, &rv_sched);
-       return 0;
+       return rv_register_monitor(&rv_scpd, &rv_sched);
 }
 
 static void __exit unregister_scpd(void)
index f5037cd6214c236461c27fbc28a831de4afcb5cc..3e1ee715a0fbf9e7e16ae67f4eb0ae5d37ed8e63 100644 (file)
@@ -79,8 +79,7 @@ static struct rv_monitor rv_sncid = {
 
 static int __init register_sncid(void)
 {
-       rv_register_monitor(&rv_sncid, &rv_sched);
-       return 0;
+       return rv_register_monitor(&rv_sncid, &rv_sched);
 }
 
 static void __exit unregister_sncid(void)
index 0076ba6d7ea447658ee353d523d7466400f4c63b..2adc3108d60c9dec773ec83cf93d69082e8e862d 100644 (file)
@@ -79,8 +79,7 @@ static struct rv_monitor rv_snep = {
 
 static int __init register_snep(void)
 {
-       rv_register_monitor(&rv_snep, &rv_sched);
-       return 0;
+       return rv_register_monitor(&rv_snep, &rv_sched);
 }
 
 static void __exit unregister_snep(void)
index bb1f60d55296095ec8d831210d6b4fdf2ce16a0e..540e686e699f4c63c9e4a87d1c8a836aaefc6da1 100644 (file)
@@ -68,8 +68,7 @@ static struct rv_monitor rv_snroc = {
 
 static int __init register_snroc(void)
 {
-       rv_register_monitor(&rv_snroc, &rv_sched);
-       return 0;
+       return rv_register_monitor(&rv_snroc, &rv_sched);
 }
 
 static void __exit unregister_snroc(void)
index 542787e6524fc5afd936723d5151517c0f2e545e..0452fcd9edcfe26451a73274fe765988fc4f9881 100644 (file)
@@ -74,8 +74,7 @@ static struct rv_monitor rv_tss = {
 
 static int __init register_tss(void)
 {
-       rv_register_monitor(&rv_tss, &rv_sched);
-       return 0;
+       return rv_register_monitor(&rv_tss, &rv_sched);
 }
 
 static void __exit unregister_tss(void)
index ed758fec8608f5b6a7bf71c59f3d18e24d91e590..4b4e99615a11fb1139a59ac43c4d4cb9b330b4ed 100644 (file)
@@ -71,8 +71,7 @@ static struct rv_monitor rv_wip = {
 
 static int __init register_wip(void)
 {
-       rv_register_monitor(&rv_wip, NULL);
-       return 0;
+       return rv_register_monitor(&rv_wip, NULL);
 }
 
 static void __exit unregister_wip(void)
index 172f31c4b0f3497833089c2e04bb14beb7545cf7..4145bea2729e132864d0e7980db054fc2dcc7c73 100644 (file)
@@ -70,8 +70,7 @@ static struct rv_monitor rv_wwnr = {
 
 static int __init register_wwnr(void)
 {
-       rv_register_monitor(&rv_wwnr, NULL);
-       return 0;
+       return rv_register_monitor(&rv_wwnr, NULL);
 }
 
 static void __exit unregister_wwnr(void)
index 89fc17cf8958e0d86c947cd4eef2368712210748..7d9b2f95c7e95d995be6b40890ebf8fde0f13904 100644 (file)
@@ -21,8 +21,7 @@ struct rv_monitor rv_%%MODEL_NAME%% = {
 
 static int __init register_%%MODEL_NAME%%(void)
 {
-       rv_register_monitor(&rv_%%MODEL_NAME%%, NULL);
-       return 0;
+       return rv_register_monitor(&rv_%%MODEL_NAME%%, NULL);
 }
 
 static void __exit unregister_%%MODEL_NAME%%(void)
index 83044a20c89aab8b3164de7d4f8adc5978fe4d50..e0fd1134bd8584309fe2b7e441781cea54728406 100644 (file)
@@ -74,8 +74,7 @@ static struct rv_monitor rv_%%MODEL_NAME%% = {
 
 static int __init register_%%MODEL_NAME%%(void)
 {
-       rv_register_monitor(&rv_%%MODEL_NAME%%, %%PARENT%%);
-       return 0;
+       return rv_register_monitor(&rv_%%MODEL_NAME%%, %%PARENT%%);
 }
 
 static void __exit unregister_%%MODEL_NAME%%(void)