]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ACPI: PMIC: Use sizeof() instead of hard coded value
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 6 Jun 2024 20:54:14 +0000 (23:54 +0300)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 13 Jun 2024 19:22:49 +0000 (21:22 +0200)
It's better to use sizeof() of a given buffer than spreading
a hard coded value.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/pmic/intel_pmic_chtdc_ti.c
drivers/acpi/pmic/intel_pmic_xpower.c

index c84ef3d151819b0a09f687753946240538d13b60..35744a0307aa466758f9994463cc762d63e3be44 100644 (file)
@@ -87,7 +87,7 @@ static int chtdc_ti_pmic_get_raw_temp(struct regmap *regmap, int reg)
 {
        u8 buf[2];
 
-       if (regmap_bulk_read(regmap, reg, buf, 2))
+       if (regmap_bulk_read(regmap, reg, buf, sizeof(buf)))
                return -EIO;
 
        /* stored in big-endian */
index 61bbe4c24d8729ef596d57ec7a4371b9c61e2b91..33c5e85294cd691b0cd5c727d41d991e7ea8a121 100644 (file)
@@ -255,7 +255,7 @@ static int intel_xpower_pmic_get_raw_temp(struct regmap *regmap, int reg)
        if (ret)
                return ret;
 
-       ret = regmap_bulk_read(regmap, AXP288_GP_ADC_H, buf, 2);
+       ret = regmap_bulk_read(regmap, AXP288_GP_ADC_H, buf, sizeof(buf));
        if (ret == 0)
                ret = (buf[0] << 4) + ((buf[1] >> 4) & 0x0f);