]> git.ipfire.org Git - thirdparty/git.git/commitdiff
t9141: use test_path_is_missing()
authorDenton Liu <liu.denton@gmail.com>
Mon, 20 Apr 2020 08:54:42 +0000 (04:54 -0400)
committerJunio C Hamano <gitster@pobox.com>
Mon, 20 Apr 2020 20:12:13 +0000 (13:12 -0700)
The test_must_fail() function should only be used for git commands since
we assume that external commands work sanely. Since, not only should
these directories not exist, but there shouldn't exist _any_ filesystem
entity in these paths, replace `test_must_fail test -d` with
`test_path_is_missing`.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t9141-git-svn-multiple-branches.sh

index 8e7f7d68b7349cdbb11ee9337444c066ae590f99..bf168a3645a796b3cc533ac1a9dcae34a75dff8c 100755 (executable)
@@ -90,10 +90,10 @@ test_expect_success 'Multiple branch or tag paths require -d' '
        ) &&
        ( cd svn_project &&
                svn_cmd up &&
-               test_must_fail test -d b_one/Nope &&
-               test_must_fail test -d b_two/Nope &&
-               test_must_fail test -d tags_A/Tagless &&
-               test_must_fail test -d tags_B/Tagless
+               test_path_is_missing b_one/Nope &&
+               test_path_is_missing b_two/Nope &&
+               test_path_is_missing tags_A/Tagless &&
+               test_path_is_missing tags_B/Tagless
        )
 '