]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mmc: dw_mmc-rockchip: Add internal phase support
authorShawn Lin <shawn.lin@rock-chips.com>
Wed, 28 Aug 2024 15:24:55 +0000 (15:24 +0000)
committerUlf Hansson <ulf.hansson@linaro.org>
Tue, 3 Sep 2024 12:11:44 +0000 (14:11 +0200)
Some Rockchip devices put the phase settings into the dw_mmc controller.

When the feature is present, the ciu-drive and ciu-sample clocks are
not used and the phase configuration is done directly through the mmc
controller.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
Acked-by: Shawn Lin <shawn.lin@rock-chips.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/010201919996fdae-8a9f843e-00a8-4131-98bf-a9da4ed04bfd-000000@eu-west-1.amazonses.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/dw_mmc-rockchip.c

index b07190ba4b7acbcb67d0b6bd87956828a2add33f..75e9ac4bcd083c84feca582dacc2e05309bf7ff1 100644 (file)
 #include "dw_mmc.h"
 #include "dw_mmc-pltfm.h"
 
-#define RK3288_CLKGEN_DIV      2
+#define RK3288_CLKGEN_DIV              2
+#define SDMMC_TIMING_CON0              0x130
+#define SDMMC_TIMING_CON1              0x134
+#define ROCKCHIP_MMC_DELAY_SEL         BIT(10)
+#define ROCKCHIP_MMC_DEGREE_MASK       0x3
+#define ROCKCHIP_MMC_DEGREE_OFFSET     1
+#define ROCKCHIP_MMC_DELAYNUM_OFFSET   2
+#define ROCKCHIP_MMC_DELAYNUM_MASK     (0xff << ROCKCHIP_MMC_DELAYNUM_OFFSET)
+#define ROCKCHIP_MMC_DELAY_ELEMENT_PSEC        60
+#define HIWORD_UPDATE(val, mask, shift) \
+               ((val) << (shift) | (mask) << ((shift) + 16))
 
 static const unsigned int freqs[] = { 100000, 200000, 300000, 400000 };
 
@@ -24,8 +34,143 @@ struct dw_mci_rockchip_priv_data {
        struct clk              *sample_clk;
        int                     default_sample_phase;
        int                     num_phases;
+       bool                    internal_phase;
 };
 
+/*
+ * Each fine delay is between 44ps-77ps. Assume each fine delay is 60ps to
+ * simplify calculations. So 45degs could be anywhere between 33deg and 57.8deg.
+ */
+static int rockchip_mmc_get_internal_phase(struct dw_mci *host, bool sample)
+{
+       unsigned long rate = clk_get_rate(host->ciu_clk);
+       u32 raw_value;
+       u16 degrees;
+       u32 delay_num = 0;
+
+       /* Constant signal, no measurable phase shift */
+       if (!rate)
+               return 0;
+
+       if (sample)
+               raw_value = mci_readl(host, TIMING_CON1);
+       else
+               raw_value = mci_readl(host, TIMING_CON0);
+
+       raw_value >>= ROCKCHIP_MMC_DEGREE_OFFSET;
+       degrees = (raw_value & ROCKCHIP_MMC_DEGREE_MASK) * 90;
+
+       if (raw_value & ROCKCHIP_MMC_DELAY_SEL) {
+               /* degrees/delaynum * 1000000 */
+               unsigned long factor = (ROCKCHIP_MMC_DELAY_ELEMENT_PSEC / 10) *
+                                       36 * (rate / 10000);
+
+               delay_num = (raw_value & ROCKCHIP_MMC_DELAYNUM_MASK);
+               delay_num >>= ROCKCHIP_MMC_DELAYNUM_OFFSET;
+               degrees += DIV_ROUND_CLOSEST(delay_num * factor, 1000000);
+       }
+
+       return degrees % 360;
+}
+
+static int rockchip_mmc_get_phase(struct dw_mci *host, bool sample)
+{
+       struct dw_mci_rockchip_priv_data *priv = host->priv;
+       struct clk *clock = sample ? priv->sample_clk : priv->drv_clk;
+
+       if (priv->internal_phase)
+               return rockchip_mmc_get_internal_phase(host, sample);
+       else
+               return clk_get_phase(clock);
+}
+
+static int rockchip_mmc_set_internal_phase(struct dw_mci *host, bool sample, int degrees)
+{
+       unsigned long rate = clk_get_rate(host->ciu_clk);
+       u8 nineties, remainder;
+       u8 delay_num;
+       u32 raw_value;
+       u32 delay;
+
+       /*
+        * The below calculation is based on the output clock from
+        * MMC host to the card, which expects the phase clock inherits
+        * the clock rate from its parent, namely the output clock
+        * provider of MMC host. However, things may go wrong if
+        * (1) It is orphan.
+        * (2) It is assigned to the wrong parent.
+        *
+        * This check help debug the case (1), which seems to be the
+        * most likely problem we often face and which makes it difficult
+        * for people to debug unstable mmc tuning results.
+        */
+       if (!rate) {
+               dev_err(host->dev, "%s: invalid clk rate\n", __func__);
+               return -EINVAL;
+       }
+
+       nineties = degrees / 90;
+       remainder = (degrees % 90);
+
+       /*
+        * Due to the inexact nature of the "fine" delay, we might
+        * actually go non-monotonic.  We don't go _too_ monotonic
+        * though, so we should be OK.  Here are options of how we may
+        * work:
+        *
+        * Ideally we end up with:
+        *   1.0, 2.0, ..., 69.0, 70.0, ...,  89.0, 90.0
+        *
+        * On one extreme (if delay is actually 44ps):
+        *   .73, 1.5, ..., 50.6, 51.3, ...,  65.3, 90.0
+        * The other (if delay is actually 77ps):
+        *   1.3, 2.6, ..., 88.6. 89.8, ..., 114.0, 90
+        *
+        * It's possible we might make a delay that is up to 25
+        * degrees off from what we think we're making.  That's OK
+        * though because we should be REALLY far from any bad range.
+        */
+
+       /*
+        * Convert to delay; do a little extra work to make sure we
+        * don't overflow 32-bit / 64-bit numbers.
+        */
+       delay = 10000000; /* PSECS_PER_SEC / 10000 / 10 */
+       delay *= remainder;
+       delay = DIV_ROUND_CLOSEST(delay,
+                       (rate / 1000) * 36 *
+                               (ROCKCHIP_MMC_DELAY_ELEMENT_PSEC / 10));
+
+       delay_num = (u8) min_t(u32, delay, 255);
+
+       raw_value = delay_num ? ROCKCHIP_MMC_DELAY_SEL : 0;
+       raw_value |= delay_num << ROCKCHIP_MMC_DELAYNUM_OFFSET;
+       raw_value |= nineties;
+
+       if (sample)
+               mci_writel(host, TIMING_CON1, HIWORD_UPDATE(raw_value, 0x07ff, 1));
+       else
+               mci_writel(host, TIMING_CON0, HIWORD_UPDATE(raw_value, 0x07ff, 1));
+
+       dev_dbg(host->dev, "set %s_phase(%d) delay_nums=%u actual_degrees=%d\n",
+               sample ? "sample" : "drv", degrees, delay_num,
+               rockchip_mmc_get_phase(host, sample)
+       );
+
+       return 0;
+}
+
+static int rockchip_mmc_set_phase(struct dw_mci *host, bool sample, int degrees)
+{
+       struct dw_mci_rockchip_priv_data *priv = host->priv;
+       struct clk *clock = sample ? priv->sample_clk : priv->drv_clk;
+
+       if (priv->internal_phase)
+               return rockchip_mmc_set_internal_phase(host, sample, degrees);
+       else
+               return clk_set_phase(clock, degrees);
+}
+
 static void dw_mci_rk3288_set_ios(struct dw_mci *host, struct mmc_ios *ios)
 {
        struct dw_mci_rockchip_priv_data *priv = host->priv;
@@ -64,7 +209,7 @@ static void dw_mci_rk3288_set_ios(struct dw_mci *host, struct mmc_ios *ios)
 
        /* Make sure we use phases which we can enumerate with */
        if (!IS_ERR(priv->sample_clk) && ios->timing <= MMC_TIMING_SD_HS)
-               clk_set_phase(priv->sample_clk, priv->default_sample_phase);
+               rockchip_mmc_set_phase(host, true, priv->default_sample_phase);
 
        /*
         * Set the drive phase offset based on speed mode to achieve hold times.
@@ -127,7 +272,7 @@ static void dw_mci_rk3288_set_ios(struct dw_mci *host, struct mmc_ios *ios)
                        break;
                }
 
-               clk_set_phase(priv->drv_clk, phase);
+               rockchip_mmc_set_phase(host, false, phase);
        }
 }
 
@@ -151,6 +296,7 @@ static int dw_mci_rk3288_execute_tuning(struct dw_mci_slot *slot, u32 opcode)
        int longest_range_len = -1;
        int longest_range = -1;
        int middle_phase;
+       int phase;
 
        if (IS_ERR(priv->sample_clk)) {
                dev_err(host->dev, "Tuning clock (sample_clk) not defined.\n");
@@ -164,8 +310,10 @@ static int dw_mci_rk3288_execute_tuning(struct dw_mci_slot *slot, u32 opcode)
 
        /* Try each phase and extract good ranges */
        for (i = 0; i < priv->num_phases; ) {
-               clk_set_phase(priv->sample_clk,
-                             TUNING_ITERATION_TO_PHASE(i, priv->num_phases));
+               rockchip_mmc_set_phase(host, true,
+                                      TUNING_ITERATION_TO_PHASE(
+                                               i,
+                                               priv->num_phases));
 
                v = !mmc_send_tuning(mmc, opcode, NULL);
 
@@ -211,7 +359,8 @@ static int dw_mci_rk3288_execute_tuning(struct dw_mci_slot *slot, u32 opcode)
        }
 
        if (ranges[0].start == 0 && ranges[0].end == priv->num_phases - 1) {
-               clk_set_phase(priv->sample_clk, priv->default_sample_phase);
+               rockchip_mmc_set_phase(host, true, priv->default_sample_phase);
+
                dev_info(host->dev, "All phases work, using default phase %d.",
                         priv->default_sample_phase);
                goto free;
@@ -248,12 +397,10 @@ static int dw_mci_rk3288_execute_tuning(struct dw_mci_slot *slot, u32 opcode)
 
        middle_phase = ranges[longest_range].start + longest_range_len / 2;
        middle_phase %= priv->num_phases;
-       dev_info(host->dev, "Successfully tuned phase to %d\n",
-                TUNING_ITERATION_TO_PHASE(middle_phase, priv->num_phases));
+       phase = TUNING_ITERATION_TO_PHASE(middle_phase, priv->num_phases);
+       dev_info(host->dev, "Successfully tuned phase to %d\n", phase);
 
-       clk_set_phase(priv->sample_clk,
-                     TUNING_ITERATION_TO_PHASE(middle_phase,
-                                               priv->num_phases));
+       rockchip_mmc_set_phase(host, true, phase);
 
 free:
        kfree(ranges);
@@ -287,6 +434,8 @@ static int dw_mci_rk3288_parse_dt(struct dw_mci *host)
 
        host->priv = priv;
 
+       priv->internal_phase = false;
+
        return 0;
 }