Mark internal utmp functions with attribute_hidden [BZ #18822]

Mark internal utmp functions with attribute_hidden to allow direct
access within libc.so and libc.a without using GOT nor PLT.

	[BZ #18822]
	* include/utmp.h (__updwtmp): Add libc_hidden_proto.
	(__getutent): Likewise.
	(__getutid): Likewise.
	(__getutline): Likewise.
	(__pututline): Likewise.
	(__getutent_r): Likewise.
	(__getutid_r): Likewise.
	(__getutline_r): Likewise.
	(__utmpname): Add attribute_hidden.
	(__setutent): Likewise.
	(__endutent): Likewise.
	* login/getutent.c (__getutent): Add libc_hidden_def.
	* login/getutent_r.c (__getutent_r): Likewise.
	(__pututline): Likewise.
	* login/getutid.c (__getutid): Likewise.
	* login/getutid_r.c (__getutid_r): Likewise.
	* login/getutline.c (__getutline): Likewise.
	* login/getutline_r.c (__getutline_r): Likewise.
	* login/updwtmp.c (__updwtmp): Likewise.

diff --git a/ChangeLog b/ChangeLog
index 628b11452f9e110ab0e495ec73133312632e6a50..4ee574002d1de1dffabd1f6541195e8eca638526 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,26 @@
+2017-10-01  H.J. Lu  <hongjiu.lu@intel.com>
+
+       [BZ #18822]
+       * include/utmp.h (__updwtmp): Add libc_hidden_proto.
+       (__getutent): Likewise.
+       (__getutid): Likewise.
+       (__getutline): Likewise.
+       (__pututline): Likewise.
+       (__getutent_r): Likewise.
+       (__getutid_r): Likewise.
+       (__getutline_r): Likewise.
+       (__utmpname): Add attribute_hidden.
+       (__setutent): Likewise.
+       (__endutent): Likewise.
+       * login/getutent.c (__getutent): Add libc_hidden_def.
+       * login/getutent_r.c (__getutent_r): Likewise.
+       (__pututline): Likewise.
+       * login/getutid.c (__getutid): Likewise.
+       * login/getutid_r.c (__getutid_r): Likewise.
+       * login/getutline.c (__getutline): Likewise.
+       * login/getutline_r.c (__getutline_r): Likewise.
+       * login/updwtmp.c (__updwtmp): Likewise.
+
 2017-10-01  H.J. Lu  <hongjiu.lu@intel.com>
 
        [BZ #18822]

diff --git a/include/utmp.h b/include/utmp.h
index 6b2e262362d7fb1b3025ffbc5638e81ba9ec32c1..374184e9b24299609d88ea850af8973dca425a94 100644 (file)
--- a/include/utmp.h
+++ b/include/utmp.h
@@ -5,18 +5,26 @@
 
 /* Now define the internal interfaces.  */
 extern void __updwtmp (const char *__wtmp_file, const struct utmp *__utmp);
-extern int __utmpname (const char *__file);
+libc_hidden_proto (__updwtmp)
+extern int __utmpname (const char *__file) attribute_hidden;
 extern struct utmp *__getutent (void);
-extern void __setutent (void);
-extern void __endutent (void);
+libc_hidden_proto (__getutent)
+extern void __setutent (void) attribute_hidden;
+extern void __endutent (void) attribute_hidden;
 extern struct utmp *__getutid (const struct utmp *__id);
+libc_hidden_proto (__getutid)
 extern struct utmp *__getutline (const struct utmp *__line);
+libc_hidden_proto (__getutline)
 extern struct utmp *__pututline (const struct utmp *__utmp_ptr);
+libc_hidden_proto (__pututline)
 extern int __getutent_r (struct utmp *__buffer, struct utmp **__result);
+libc_hidden_proto (__getutent_r)
 extern int __getutid_r (const struct utmp *__id, struct utmp *__buffer,
                        struct utmp **__result);
+libc_hidden_proto (__getutid_r)
 extern int __getutline_r (const struct utmp *__line,
                          struct utmp *__buffer, struct utmp **__result);
+libc_hidden_proto (__getutline_r)
 
 libutil_hidden_proto (login_tty)
 

diff --git a/login/getutent.c b/login/getutent.c
index 114f7dbbc77fbfe00abbcc1a6aecb4be4e5b8c06..2f6ccf0d3b6d6964394c0292bd30f8b793f09c5e 100644 (file)
--- a/login/getutent.c
+++ b/login/getutent.c
@@ -41,4 +41,5 @@ __getutent (void)
 
   return result;
 }
+libc_hidden_def (__getutent)
 weak_alias (__getutent, getutent)

diff --git a/login/getutent_r.c b/login/getutent_r.c
index 62272a284119566224eab8f6117f2624672dad0a..1b126f088ace235f356f301daa3d5c49cabd85bd 100644 (file)
--- a/login/getutent_r.c
+++ b/login/getutent_r.c
@@ -151,6 +151,7 @@ __getutent_r (struct utmp *buffer, struct utmp **result)
 
   return retval;
 }
+libc_hidden_def (__getutent_r)
 weak_alias (__getutent_r, getutent_r)
 
 
@@ -167,6 +168,7 @@ __pututline (const struct utmp *data)
 
   return buffer;
 }
+libc_hidden_def (__pututline)
 weak_alias (__pututline, pututline)
 
 

diff --git a/login/getutid.c b/login/getutid.c
index 003bc657e65cb20b62d34333b4f33cf1566c1914..62924f0fcf6b8ce2ff47c561f4890955af0ddb4e 100644 (file)
--- a/login/getutid.c
+++ b/login/getutid.c
@@ -39,4 +39,5 @@ __getutid (const struct utmp *id)
 
   return result;
 }
+libc_hidden_def (__getutid)
 weak_alias (__getutid, getutid)

diff --git a/login/getutid_r.c b/login/getutid_r.c
index f82301322f1567ca8eade7ef56238c6fed21edb4..36ddbb228a3bc11e753e4b01fc329dadd09ecd18 100644 (file)
--- a/login/getutid_r.c
+++ b/login/getutid_r.c
@@ -59,4 +59,5 @@ __getutid_r (const struct utmp *id, struct utmp *buffer, struct utmp **result)
   return -1;
 #endif
 }
+libc_hidden_def (__getutid_r)
 weak_alias (__getutid_r, getutid_r)

diff --git a/login/getutline.c b/login/getutline.c
index f5291e8a8ed8ef36d2b729301a533c3b2de4aa86..636b8feec81f704b43219ed785b21dc89aa8d9af 100644 (file)
--- a/login/getutline.c
+++ b/login/getutline.c
@@ -40,4 +40,5 @@ __getutline (const struct utmp *line)
 
   return result;
 }
+libc_hidden_def (__getutline)
 weak_alias (__getutline, getutline)

diff --git a/login/getutline_r.c b/login/getutline_r.c
index 1a6f1688ee6ac52d9331b8a4330c97060dbc2381..3adc3d0d663ae86cfd4a9ce9a6fa50ed7fb8c274 100644 (file)
--- a/login/getutline_r.c
+++ b/login/getutline_r.c
@@ -42,4 +42,5 @@ __getutline_r (const struct utmp *line, struct utmp *buffer,
 
   return retval;
 }
+libc_hidden_def (__getutline_r)
 weak_alias (__getutline_r, getutline_r)

diff --git a/login/updwtmp.c b/login/updwtmp.c
index 7788614ed3ce7ec487aad648bfd782c2d49dd595..3fcbaf643de4117879d151fd0bc13c448d447bc7 100644 (file)
--- a/login/updwtmp.c
+++ b/login/updwtmp.c
@@ -31,4 +31,5 @@ __updwtmp (const char *wtmp_file, const struct utmp *utmp)
 
   (*__libc_utmp_file_functions.updwtmp) (file_name, utmp);
 }
+libc_hidden_def (__updwtmp)
 weak_alias (__updwtmp, updwtmp)