Performance optimization in sqlite3BtreeInsert().

FossilOrigin-Name: 9776fa31758161970a50995a487b6543ed71e9610460b7324304ef21d9248707

diff --git a/manifest b/manifest
index e9ef88380cdfe015804e879ed8fb6e2005d7bcde..740a9fb5eba6ed74c219c4ad492b46706f6e6927 100644 (file)
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Performance\simprovement\sand\ssize\sreduction\sin\sbalance_nonroot().
-D 2022-11-19T18:43:32.814
+C Performance\soptimization\sin\ssqlite3BtreeInsert().
+D 2022-11-19T19:37:26.733
 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
 F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@ -578,7 +578,7 @@ F src/auth.c f4fa91b6a90bbc8e0d0f738aa284551739c9543a367071f55574681e0f24f8cf
 F src/backup.c a2891172438e385fdbe97c11c9745676bec54f518d4447090af97189fd8e52d7
 F src/bitvec.c 7c849aac407230278445cb069bebc5f89bf2ddd87c5ed9459b070a9175707b3d
 F src/btmutex.c 6ffb0a22c19e2f9110be0964d0731d2ef1c67b5f7fabfbaeb7b9dabc4b7740ca
-F src/btree.c b9e66886f09b33cfa5058a6a3f3eddae92b5b9d566ba65bea26928f0b9860754
+F src/btree.c 52e71b216c4c8e661f01f70840d2cfe64677b07dd301e2ae684b8785328e7870
 F src/btree.h 4fcbb0b041013071dd5e9f53c538d49916c092e6ad8842185985e5270a0792de
 F src/btreeInt.h 8ce1332edd89dfd2461d561ac10a0ab5601c8e06200cb5230596c3caaf54482e
 F src/build.c d3e43e950e4e377c1d451a4862556792acdef1faba14a03f899d30d09731c48b
@@ -2057,8 +2057,8 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93
 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
 F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
 F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
-P daa07149c0a0fcb6a6a1ace6020ca68802588ed309f5aaaf99c871088bc46908
-R 486fbd2f4ae2f2943d0cbb110a637a8e
+P 715bc81eb833ad4834d139a04085e0386c54c30d7395207e48972c4dfe5879c1
+R e1e21840abf2d0e625480a11eaf71aa4
 U drh
-Z 537c9962ecec2516b80c7b85babce28a
+Z 802aa656f8405b91947fb6fe179ec5a2
 # Remove this line to create a well-formed Fossil manifest.

diff --git a/manifest.uuid b/manifest.uuid
index d910060e293ef2a71e0f2526d0027e8b74937c62..650f1faa1016bb9990f18e31cabbb0e5433fd145 100644 (file)
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-715bc81eb833ad4834d139a04085e0386c54c30d7395207e48972c4dfe5879c1
\ No newline at end of file
+9776fa31758161970a50995a487b6543ed71e9610460b7324304ef21d9248707
\ No newline at end of file

diff --git a/src/btree.c b/src/btree.c
index 965897f89498b07f0bec72ef8869babcd5a3b9f1..a79e81734e1bc265d7d6d08eb0c908338948a9db 100644 (file)
--- a/src/btree.c
+++ b/src/btree.c
@@ -9182,12 +9182,13 @@ int sqlite3BtreeInsert(
       if( info.nPayload!=info.nLocal ){
         Pgno ovfl = get4byte(&newCell[szNew-4]);
         ptrmapPut(pBt, ovfl, PTRMAP_OVERFLOW1, pPage->pgno, &rc);
+        if( NEVER(rc) ) goto end_insert;
       }
     }
   }else{
     rc = fillInCell(pPage, newCell, pX, &szNew);
+    if( rc ) goto end_insert;
   }
-  if( rc ) goto end_insert;
   assert( szNew==pPage->xCellSize(pPage, newCell) );
   assert( szNew <= MX_CELL_SIZE(pBt) );
   idx = pCur->ix;