script_src => [ 'self', 'nonce', 'unsafe-inline', 'https://www.google-analytics.com' ],
frame_src => [ 'none', ],
worker_src => [ 'none', ],
- img_src => [ 'self', 'https://secure.gravatar.com' ],
+ img_src => [ 'self', 'blob:', 'https://secure.gravatar.com' ],
style_src => [ 'self', 'unsafe-inline' ],
object_src => [ 'none' ],
connect_src => [
use URI::QueryParam;
use URI::Escape qw(uri_escape_utf8);
use File::Basename qw(basename);
+use MIME::Base64 qw(decode_base64);
# For most scripts we don't make $cgi and $template global variables. But
# when preparing Bugzilla for mod_perl, this script used these
# Get the filehandle of the attachment.
my $data_fh = $cgi->upload('data');
my $attach_text = $cgi->param('attach_text');
+ my $data_base64 = $cgi->param('data_base64');
+ my $data;
+ my $filename;
if ($attach_text) {
# Convert to unix line-endings if pasting a patch
if (scalar($cgi->param('ispatch'))) {
$attach_text =~ s/[\012\015]{1,2}/\012/g;
}
+ $data = $attach_text;
+ $filename = "file_$bugid.txt";
+ } elsif ($data_base64) {
+ $data = decode_base64($data_base64);
+ $filename = $cgi->param('filename') || "file_$bugid";
+ } else {
+ $data = $filename = $data_fh;
}
my $attachment = Bugzilla::Attachment->create(
{bug => $bug,
creation_ts => $timestamp,
- data => $attach_text || $data_fh,
+ data => $data,
description => scalar $cgi->param('description'),
- filename => $attach_text ? "file_$bugid.txt" : $data_fh,
+ filename => $filename,
ispatch => scalar $cgi->param('ispatch'),
isprivate => scalar $cgi->param('isprivate'),
mimetype => $content_type,
[% IF bug.product_obj.reviewer_required %]
REVIEW.init_mandatory();
[% END %]
- REVIEW.init_create_attachment();
});
</script>
target: false,
fields: [],
use_error_for: false,
- ispatch_override: false,
- description_override: false,
- ignore_patch_event: true,
init_review_flag: function(fid, flag_name) {
var idx = this.fields.push({ 'fid': fid, 'flag_name': flag_name, 'component': '' }) - 1;
$('#component').on('change', REVIEW.component_change);
BUGZILLA.string['reviewer_required'] = 'A reviewer is required.';
this.use_error_for = true;
- this.init_create_attachment();
- },
-
- init_create_attachment: function() {
- $('#data').on('change', REVIEW.attachment_change);
- $('#description').on('change', REVIEW.description_change);
- $('#ispatch').on('change', REVIEW.ispatch_change);
},
component_change: function() {
}
},
- attachment_change: function() {
- var filename = $('#data').val().split('/').pop().split('\\').pop();
- var description = $('#description').first();
- if (description.val() == '' || !REVIEW.description_override) {
- description.val(filename);
- }
- if (!REVIEW.ispatch_override) {
- $('#ispatch').prop('checked',
- REVIEW.endsWith(filename, '.diff') || REVIEW.endsWith(filename, '.patch'));
- }
- setContentTypeDisabledState(this.form);
- description.select();
- description.focus();
- },
-
- description_change: function() {
- REVIEW.description_override = true;
- },
-
- ispatch_change: function() {
- // the attachment template triggers this change event onload
- // as we only want to set ispatch_override when the user clicks on the
- // checkbox, we ignore this first event
- if (REVIEW.ignore_patch_event) {
- REVIEW.ignore_patch_event = false;
- return;
- }
- REVIEW.ispatch_override = true;
- },
-
flag_change: function(e) {
var field = REVIEW.fields[e.data];
var suggestions_span = $('#' + field.fid + '_suggestions');
},
check_mandatory: function(e) {
- if ($('#data').length && !$('#data').val()
- && $('#attach_text').length && !$('#attach_text').val())
+ if ($('#file').length && !$('#file').val()
+ && $('#att-textarea').length && !$('#att-textarea').val())
{
return;
}
* Erik Stambaugh <erik@dasbistro.com>
* Marc Schumann <wurblzap@gmail.com>
* Guy Pyrzak <guy.pyrzak@gmail.com>
+ * Kohei Yoshino <kohei.yoshino@gmail.com>
*/
-function validateAttachmentForm(theform) {
- var desc_value = YAHOO.lang.trim(theform.description.value);
- if (desc_value == '') {
- alert(BUGZILLA.string.attach_desc_required);
- return false;
- }
- return true;
-}
-
function updateCommentPrivacy(checkbox) {
var text_elem = document.getElementById('comment');
if (checkbox.checked) {
}
}
-function setContentTypeDisabledState(form) {
- var isdisabled = false;
- if (form.ispatch.checked)
- isdisabled = true;
-
- for (var i = 0; i < form.contenttypemethod.length; i++)
- form.contenttypemethod[i].disabled = isdisabled;
-
- form.contenttypeselection.disabled = isdisabled;
- form.contenttypeentry.disabled = isdisabled;
-}
-
-function TextFieldHandler() {
- var field_text = document.getElementById("attach_text");
- var greyfields = new Array("data", "autodetect", "list", "manual",
- "contenttypeselection", "contenttypeentry");
- var i, thisfield;
- if (field_text.value.match(/^\s*$/)) {
- for (i = 0; i < greyfields.length; i++) {
- thisfield = document.getElementById(greyfields[i]);
- if (thisfield) {
- thisfield.removeAttribute("disabled");
- }
- }
- } else {
- for (i = 0; i < greyfields.length; i++) {
- thisfield = document.getElementById(greyfields[i]);
- if (thisfield) {
- thisfield.setAttribute("disabled", "disabled");
- }
- }
- }
-}
-
-function DataFieldHandler() {
- var field_data = document.getElementById("data");
- var greyfields = new Array("attach_text");
- var i, thisfield;
- if (field_data.value.match(/^\s*$/)) {
- for (i = 0; i < greyfields.length; i++) {
- thisfield = document.getElementById(greyfields[i]);
- if (thisfield) {
- thisfield.removeAttribute("disabled");
- }
- }
- } else {
- for (i = 0; i < greyfields.length; i++) {
- thisfield = document.getElementById(greyfields[i]);
- if (thisfield) {
- thisfield.setAttribute("disabled", "disabled");
- }
- }
- }
-
- // Check the current file size (in KB)
- const file_size = field_data.files[0].size / 1024;
- const max_size = BUGZILLA.param.maxattachmentsize;
- const invalid = file_size > max_size;
- const message = invalid ? `This file (<strong>${(file_size / 1024).toFixed(1)} MB</strong>) is larger than the ` +
- `maximum allowed size (<strong>${(max_size / 1024).toFixed(1)} MB</strong>).<br>Please consider uploading it ` +
- `to an online file storage and sharing the link in a bug comment instead.` : '';
- const message_short = invalid ? 'File too large' : '';
- const $error = document.querySelector('#data-error');
-
- // Show an error message if the file is too large
- $error.innerHTML = message;
- field_data.setCustomValidity(message_short);
- field_data.setAttribute('aria-invalid', invalid);
-}
-
-function clearAttachmentFields() {
- var element;
-
- document.getElementById('data').value = '';
- DataFieldHandler();
- if ((element = document.getElementById('attach_text'))) {
- element.value = '';
- TextFieldHandler();
- }
- document.getElementById('description').value = '';
- /* Fire onchange so that the disabled state of the content-type
- * radio buttons are also reset
- */
- element = document.getElementById('ispatch');
- element.checked = '';
- bz_fireEvent(element, 'change');
- if ((element = document.getElementById('isprivate')))
- element.checked = '';
-}
-
/* Functions used when viewing patches in Diff mode. */
function collapse_all() {
showElementById('undoEditButton');
} else if (mode == 'raw') {
showElementById('viewFrame');
- if (patchviewerinstalled)
+ if (patchviewerinstalled)
showElementById('viewDiffButton');
showElementById(has_edited ? 'redoEditButton' : 'editButton');
showElementById('smallCommentFrame');
} else if (mode == 'diff') {
- if (patchviewerinstalled)
+ if (patchviewerinstalled)
showElementById('viewDiffFrame');
showElementById('viewRawButton');
}
}
-function toggle_attachment_details_visibility ( )
+function toggle_attachment_details_visibility ( )
{
// show hide classes
var container = document.getElementById('attachment_info');
else {
showElementById('attachment_false');
hideElementById('attachment_true');
- clearAttachmentFields();
+ bz_attachment_form.reset_fields();
}
+
+ bz_attachment_form.update_requirements(wants_attachment);
}
+
+/**
+ * Expose an `AttachmentForm` instance on global.
+ */
+var bz_attachment_form;
+
+/**
+ * Reference or define the Bugzilla app namespace.
+ * @namespace
+ */
+var Bugzilla = Bugzilla || {};
+
+/**
+ * Implement the attachment selector functionality that can be used standalone or on the New Bug page. This supports 3
+ * input methods: traditional `<input type="file">` field, drag & dropping of a file or text, as well as copy & pasting
+ * an image or text.
+ */
+Bugzilla.AttachmentForm = class AttachmentForm {
+ /**
+ * Initialize a new `AttachmentForm` instance.
+ */
+ constructor() {
+ this.$file = document.querySelector('#att-file');
+ this.$data = document.querySelector('#att-data');
+ this.$filename = document.querySelector('#att-filename');
+ this.$dropbox = document.querySelector('#att-dropbox');
+ this.$browse_label = document.querySelector('#att-browse-label');
+ this.$textarea = document.querySelector('#att-textarea');
+ this.$preview = document.querySelector('#att-preview');
+ this.$preview_name = this.$preview.querySelector('[itemprop="name"]');
+ this.$preview_type = this.$preview.querySelector('[itemprop="encodingFormat"]');
+ this.$preview_text = this.$preview.querySelector('[itemprop="text"]');
+ this.$preview_image = this.$preview.querySelector('[itemprop="image"]');
+ this.$remove_button = document.querySelector('#att-remove-button');
+ this.$description = document.querySelector('#att-description');
+ this.$error_message = document.querySelector('#att-error-message');
+ this.$ispatch = document.querySelector('#att-ispatch');
+ this.$type_outer = document.querySelector('#att-type-outer');
+ this.$type_list = document.querySelector('#att-type-list');
+ this.$type_manual = document.querySelector('#att-type-manual');
+ this.$type_select = document.querySelector('#att-type-select');
+ this.$type_input = document.querySelector('#att-type-input');
+ this.$isprivate = document.querySelector('#isprivate');
+ this.$takebug = document.querySelector('#takebug');
+
+ // Add event listeners
+ this.$file.addEventListener('change', () => this.file_onchange());
+ this.$dropbox.addEventListener('dragover', event => this.dropbox_ondragover(event));
+ this.$dropbox.addEventListener('dragleave', () => this.dropbox_ondragleave());
+ this.$dropbox.addEventListener('dragend', () => this.dropbox_ondragend());
+ this.$dropbox.addEventListener('drop', event => this.dropbox_ondrop(event));
+ this.$browse_label.addEventListener('click', () => this.$file.click());
+ this.$textarea.addEventListener('input', () => this.textarea_oninput());
+ this.$textarea.addEventListener('paste', event => this.textarea_onpaste(event));
+ this.$remove_button.addEventListener('click', () => this.remove_button_onclick());
+ this.$description.addEventListener('input', () => this.description_oninput());
+ this.$description.addEventListener('change', () => this.description_onchange());
+ this.$ispatch.addEventListener('change', () => this.ispatch_onchange());
+ this.$type_select.addEventListener('change', () => this.type_select_onchange());
+ this.$type_input.addEventListener('change', () => this.type_input_onchange());
+
+ // Prepare the file reader
+ this.data_reader = new FileReader();
+ this.text_reader = new FileReader();
+ this.data_reader.addEventListener('load', () => this.data_reader_onload());
+ this.text_reader.addEventListener('load', () => this.text_reader_onload());
+
+ // Initialize the view
+ this.enable_keyboard_access();
+ this.reset_fields();
+ }
+
+ /**
+ * Enable keyboard access on the buttons. Treat the Enter keypress as a click.
+ */
+ enable_keyboard_access() {
+ document.querySelectorAll('#att-selector [role="button"]').forEach($button => {
+ $button.addEventListener('keypress', event => {
+ if (!event.isComposing && event.key === 'Enter') {
+ event.target.click();
+ }
+ });
+ });
+ }
+
+ /**
+ * Reset all the input fields to the initial state, and remove the preview and message.
+ */
+ reset_fields() {
+ this.description_override = false;
+ this.$file.value = this.$data.value = this.$filename.value = this.$type_input.value = this.$description.value = '';
+ this.$type_list.checked = this.$type_select.options[0].selected = true;
+
+ if (this.$isprivate) {
+ this.$isprivate.checked = this.$isprivate.disabled = false;
+ }
+
+ if (this.$takebug) {
+ this.$takebug.checked = this.$takebug.disabled = false;
+ }
+
+ this.clear_preview();
+ this.clear_error();
+ this.update_requirements();
+ this.update_text();
+ this.update_ispatch();
+ }
+
+ /**
+ * Update the `required` property on the Base64 data and Description fields.
+ * @param {Boolean} [required=true] `true` if these fields are required, `false` otherwise.
+ */
+ update_requirements(required = true) {
+ this.$data.required = this.$description.required = required;
+ this.update_validation();
+ }
+
+ /**
+ * Update the custom validation message on the Base64 data field depending on the requirement and value.
+ */
+ update_validation() {
+ this.$data.setCustomValidity(this.$data.required && !this.$data.value ? 'Please select a file or enter text.' : '');
+
+ // In Firefox, the message won't be displayed once the field becomes valid then becomes invalid again. This is a
+ // workaround for the issue.
+ this.$data.hidden = false;
+ this.$data.hidden = true;
+ }
+
+ /**
+ * Process a user-selected file for upload. Read the content if it's been transferred with a paste or drag operation.
+ * Update the Description, Content Type, etc. and show the preview.
+ * @param {File} file A file to be read.
+ * @param {Boolean} [transferred=true] `true` if the source is `DataTransfer`, `false` if it's been selected via
+ * `<input type="file">`.
+ */
+ process_file(file, transferred = true) {
+ // Check for patches which should have the `text/plain` MIME type
+ const is_patch = !!file.name.match(/\.(?:diff|patch)$/) || !!file.type.match(/^text\/x-(?:diff|patch)$/);
+ // Check for text files which may have no MIME type or `application/*` MIME type
+ const is_text = !!file.name.match(/\.(?:cpp|es|h|js|json|markdown|md|rs|rst|sh|toml|ts|tsx|xml|yaml|yml)$/);
+ // Reassign the MIME type
+ const type = is_patch || (is_text && !file.type) ? 'text/plain' : (file.type || 'application/octet-stream');
+
+ if (this.check_file_size(file.size)) {
+ this.$data.required = transferred;
+
+ if (transferred) {
+ this.data_reader.readAsDataURL(file);
+ this.$file.value = '';
+ this.$filename.value = file.name.replace(/\s/g, '-');
+ } else {
+ this.$data.value = this.$filename.value = '';
+ }
+ } else {
+ this.$data.required = true;
+ this.$file.value = this.$data.value = this.$filename.value = '';
+ }
+
+ this.update_validation();
+ this.show_preview(file, file.type.startsWith('text/') || is_patch || is_text);
+ this.update_text();
+ this.update_content_type(type);
+ this.update_ispatch(is_patch);
+
+ if (!this.description_override) {
+ this.$description.value = file.name;
+ }
+
+ this.$textarea.hidden = true;
+ this.$description.select();
+ this.$description.focus();
+ }
+
+ /**
+ * Check the current file size and show an error message if it exceeds the application-defined limit.
+ * @param {Number} size A file size in bytes.
+ * @returns {Boolean} `true` if the file is less than the maximum allowed size, `false` otherwise.
+ */
+ check_file_size(size) {
+ const file_size = size / 1024; // Convert to KB
+ const max_size = BUGZILLA.param.maxattachmentsize; // Defined in KB
+ const invalid = file_size > max_size;
+ const message = invalid ?
+ `This file (<strong>${(file_size / 1024).toFixed(1)} MB</strong>) is larger than the maximum allowed size ` +
+ `(<strong>${(max_size / 1024).toFixed(1)} MB</strong>). Please consider uploading it to an online file storage ` +
+ 'and sharing the link in a bug comment instead.' : '';
+ const message_short = invalid ? 'File too large' : '';
+
+ this.$error_message.innerHTML = message;
+ this.$data.setCustomValidity(message_short);
+ this.$data.setAttribute('aria-invalid', invalid);
+ this.$dropbox.classList.toggle('invalid', invalid);
+
+ return !invalid;
+ }
+
+ /**
+ * Called whenever a file's data URL is read by `FileReader`. Embed the Base64-encoded content for upload.
+ */
+ data_reader_onload() {
+ this.$data.value = this.data_reader.result.split(',')[1];
+ this.update_validation();
+ }
+
+ /**
+ * Called whenever a file's text content is read by `FileReader`. Show the preview of the first 10 lines.
+ */
+ text_reader_onload() {
+ this.$preview_text.textContent = this.text_reader.result.split(/\r\n|\r|\n/, 10).join('\n');
+ }
+
+ /**
+ * Called whenever a file is selected by the user by using the file picker. Prepare for upload.
+ */
+ file_onchange() {
+ this.process_file(this.$file.files[0], false);
+ }
+
+ /**
+ * Called whenever a file is being dragged on the drop target. Allow the `copy` drop effect, and set a class name on
+ * the drop target for styling.
+ * @param {DragEvent} event A `dragover` event.
+ */
+ dropbox_ondragover(event) {
+ event.preventDefault();
+ event.dataTransfer.dropEffect = event.dataTransfer.effectAllowed = 'copy';
+
+ if (!this.$dropbox.classList.contains('dragover')) {
+ this.$dropbox.classList.add('dragover');
+ }
+ }
+
+ /**
+ * Called whenever a dragged file leaves the drop target. Reset the styling.
+ */
+ dropbox_ondragleave() {
+ this.$dropbox.classList.remove('dragover');
+ }
+
+ /**
+ * Called whenever a drag operation is being ended. Reset the styling.
+ */
+ dropbox_ondragend() {
+ this.$dropbox.classList.remove('dragover');
+ }
+
+ /**
+ * Called whenever a file or text is dropped on the drop target. If it's a file, read the content. If it's plaintext,
+ * fill in the textarea.
+ * @param {DragEvent} event A `drop` event.
+ */
+ dropbox_ondrop(event) {
+ event.preventDefault();
+
+ const files = event.dataTransfer.files;
+ const text = event.dataTransfer.getData('text');
+
+ if (files.length > 0) {
+ this.process_file(files[0]);
+ } else if (text) {
+ this.clear_preview();
+ this.clear_error();
+ this.update_text(text);
+ }
+
+ this.$dropbox.classList.remove('dragover');
+ }
+
+ /**
+ * Insert text to the textarea, and show it if it's not empty.
+ * @param {String} [text=''] Text to be inserted.
+ */
+ update_text(text = '') {
+ this.$textarea.value = text;
+ this.textarea_oninput();
+
+ if (text) {
+ this.$textarea.hidden = false;
+ }
+ }
+
+ /**
+ * Called whenever the content of the textarea is updated. Update the Content Type, `required` property, etc.
+ */
+ textarea_oninput() {
+ const text = this.$textarea.value.trim();
+ const has_text = !!text;
+ const is_patch = !!text.match(/^(?:diff|---)\s/);
+ const is_ghpr = !!text.match(/^https:\/\/github\.com\/[\w\-]+\/[\w\-]+\/pull\/\d+\/?$/);
+
+ if (has_text) {
+ this.$file.value = this.$data.value = this.$filename.value = '';
+ this.update_content_type('text/plain');
+ }
+
+ if (!this.description_override) {
+ this.$description.value = is_patch ? 'patch' : is_ghpr ? 'GitHub Pull Request' : '';
+ }
+
+ this.$data.required = !has_text && !this.$file.value;
+ this.update_validation();
+ this.$type_input.value = is_ghpr ? 'text/x-github-pull-request' : '';
+ this.update_ispatch(is_patch);
+ this.$type_outer.querySelectorAll('[name]').forEach($input => $input.disabled = has_text);
+ }
+
+ /**
+ * Called whenever a string or data is pasted from clipboard to the textarea. If it contains a regular image, read the
+ * content for upload.
+ * @param {ClipboardEvent} event A `paste` event.
+ */
+ textarea_onpaste(event) {
+ const image = [...event.clipboardData.items].find(item => item.type.match(/^image\/(?!vnd)/));
+
+ if (image) {
+ this.process_file(image.getAsFile());
+ this.update_ispatch(false, true);
+ }
+ }
+
+ /**
+ * Show the preview of a user-selected file. Display a thumbnail if it's a regular image (PNG, GIF, JPEG, etc.) or
+ * small plaintext file.
+ * @param {File} file A file to be previewed.
+ * @param {Boolean} [is_text=false] `true` if the file is a plaintext file, `false` otherwise.
+ */
+ show_preview(file, is_text = false) {
+ this.$preview_name.textContent = file.name;
+ this.$preview_type.content = file.type;
+ this.$preview_text.textContent = '';
+ this.$preview_image.src = file.type.match(/^image\/(?!vnd)/) ? URL.createObjectURL(file) : '';
+ this.$preview.hidden = false;
+
+ if (is_text && file.size < 500000) {
+ this.text_reader.readAsText(file);
+ }
+ }
+
+ /**
+ * Remove the preview.
+ */
+ clear_preview() {
+ URL.revokeObjectURL(this.$preview_image.src);
+
+ this.$preview_name.textContent = this.$preview_type.content = '';
+ this.$preview_text.textContent = this.$preview_image.src = '';
+ this.$preview.hidden = true;
+ }
+
+ /**
+ * Called whenever the Remove buttons is clicked by the user. Reset all the fields and focus the textarea for further
+ * input.
+ */
+ remove_button_onclick() {
+ this.reset_fields();
+
+ this.$textarea.hidden = false;
+ this.$textarea.focus();
+ }
+
+ /**
+ * Remove the error message if any.
+ */
+ clear_error() {
+ this.check_file_size(0);
+ }
+
+ /**
+ * Called whenever the Description is updated. Update the Patch checkbox when needed.
+ */
+ description_oninput() {
+ if (this.$description.value.match(/\bpatch\b/i) && !this.$ispatch.checked) {
+ this.update_ispatch(true);
+ }
+ }
+
+ /**
+ * Called whenever the Description is changed manually. Set the override flag so the user-defined Description will be
+ * retained later on.
+ */
+ description_onchange() {
+ this.description_override = true;
+ }
+
+ /**
+ * Select a Content Type from the list or fill in the "enter manually" field if the option is not available.
+ * @param {String} type A detected MIME type.
+ */
+ update_content_type(type) {
+ if ([...this.$type_select.options].find($option => $option.value === type)) {
+ this.$type_list.checked = true;
+ this.$type_select.value = type;
+ this.$type_input.value = '';
+ } else {
+ this.$type_manual.checked = true;
+ this.$type_input.value = type;
+ }
+ }
+
+ /**
+ * Update the Patch checkbox state.
+ * @param {Boolean} [checked=false] The `checked` property of the checkbox.
+ * @param {Boolean} [disabled=false] The `disabled` property of the checkbox.
+ */
+ update_ispatch(checked = false, disabled = false) {
+ this.$ispatch.checked = checked;
+ this.$ispatch.disabled = disabled;
+ this.ispatch_onchange();
+ }
+
+ /**
+ * Called whenever the Patch checkbox is checked or unchecked. Disable or enable the Content Type fields accordingly.
+ */
+ ispatch_onchange() {
+ const is_patch = this.$ispatch.checked;
+ const is_ghpr = this.$type_input.value === 'text/x-github-pull-request';
+
+ this.$type_outer.querySelectorAll('[name]').forEach($input => $input.disabled = is_patch);
+
+ if (is_patch) {
+ this.update_content_type('text/plain');
+ }
+
+ // Reassign the bug to the user if the attachment is a patch or GitHub Pull Request
+ if (this.$takebug && this.$takebug.clientHeight > 0 && this.$takebug.dataset.takeIfPatch) {
+ this.$takebug.checked = is_patch || is_ghpr;
+ }
+ }
+
+ /**
+ * Called whenever an option is selected from the Content Type list. Select the "select from list" radio button.
+ */
+ type_select_onchange() {
+ this.$type_list.checked = true;
+ }
+
+ /**
+ * Called whenever the used manually specified the Content Type. Select the "select from list" or "enter manually"
+ * radio button depending on the value.
+ */
+ type_input_onchange() {
+ if (this.$type_input.value) {
+ this.$type_manual.checked = true;
+ } else {
+ this.$type_list.checked = this.$type_select.options[0].selected = true;
+ }
+ }
+};
+
+window.addEventListener('DOMContentLoaded', () => bz_attachment_form = new Bugzilla.AttachmentForm(), { once: true });
use Bugzilla::Flag;
use List::MoreUtils qw(uniq);
+use MIME::Base64 qw(decode_base64);
my $user = Bugzilla->login(LOGIN_REQUIRED);
# Add an attachment if requested.
my $data_fh = $cgi->upload('data');
my $attach_text = $cgi->param('attach_text');
+my $data_base64 = $cgi->param('data_base64');
-if ($data_fh || $attach_text) {
+if ($data_fh || $attach_text || $data_base64) {
$cgi->param('isprivate', $cgi->param('comment_is_private'));
# Must be called before create() as it may alter $cgi->param('ispatch').
my $content_type = Bugzilla::Attachment::get_content_type();
my $attachment;
+ my $data;
+ my $filename;
+
+ if ($attach_text) {
+ # Convert to unix line-endings if pasting a patch
+ if (scalar($cgi->param('ispatch'))) {
+ $attach_text =~ s/[\012\015]{1,2}/\012/g;
+ }
+ $data = $attach_text;
+ $filename = "file_$id.txt";
+ } elsif ($data_base64) {
+ $data = decode_base64($data_base64);
+ $filename = $cgi->param('filename') || "file_$id";
+ } else {
+ $data = $filename = $data_fh;
+ }
# If the attachment cannot be successfully added to the bug,
# we notify the user, but we don't interrupt the bug creation process.
$attachment = Bugzilla::Attachment->create(
{bug => $bug,
creation_ts => $timestamp,
- data => $attach_text || $data_fh,
+ data => $data,
description => scalar $cgi->param('description'),
- filename => $attach_text ? "file_$id.txt" : $data_fh,
+ filename => $filename,
ispatch => scalar $cgi->param('ispatch'),
isprivate => scalar $cgi->param('isprivate'),
mimetype => $content_type,
$sel->click_ok("link=Add an attachment");
$sel->wait_for_page_to_load_ok(WAIT_TIME);
$sel->title_is("Create New Attachment for Bug #$bug1_id");
-$sel->attach_file("data", $config->{attachment_file});
-$sel->type_ok("description", "patch, v1");
-$sel->check_ok("ispatch");
+$sel->attach_file('//input[@name="data"]', $config->{attachment_file});
+$sel->type_ok('//input[@name="description"]', "patch, v1");
+$sel->check_ok('//input[@name="ispatch"]');
$sel->is_text_present_ok("SeleniumAttachmentFlag1Test");
$sel->is_text_present_ok("SeleniumAttachmentFlag2Test");
ok(!$sel->is_text_present("SeleniumAttachmentFlag3Test"), "Inactive SeleniumAttachmentFlag3Test flag type not displayed");
$sel->click_ok("//a[contains(text(),'Create\n Another Attachment to Bug $bug1_id')]");
$sel->wait_for_page_to_load_ok(WAIT_TIME);
$sel->title_is("Create New Attachment for Bug #$bug1_id");
-$sel->attach_file("data", $config->{attachment_file});
-$sel->type_ok("description", "patch, v2");
-$sel->check_ok("ispatch");
+$sel->attach_file('//input[@name="data"]', $config->{attachment_file});
+$sel->type_ok('//input[@name="description"]', "patch, v2");
+$sel->check_ok('//input[@name="ispatch"]');
# Mark the previous attachment as obsolete.
$sel->check_ok($attachment1_id);
$sel->select_ok("flag_type-$aflagtype1_id", "label=?");
$sel->click_ok("//a[contains(text(),'Create\n Another Attachment to Bug $bug1_id')]");
$sel->wait_for_page_to_load_ok(WAIT_TIME);
$sel->title_is("Create New Attachment for Bug #$bug1_id");
-$sel->attach_file("data", $config->{attachment_file});
-$sel->type_ok("description", "patch, v3");
-$sel->click_ok("list");
-$sel->select_ok("contenttypeselection", "label=plain text (text/plain)");
+$sel->attach_file('//input[@name="data"]', $config->{attachment_file});
+$sel->type_ok('//input[@name="description"]', "patch, v3");
+$sel->click_ok('//input[@name="contenttypemethod" and @value="list"]');
+$sel->select_ok('//select[@name="contenttypeselection"]', "label=plain text (text/plain)");
$sel->select_ok("flag_type-$aflagtype1_id", "label=+");
$sel->type_ok("comment", "one +, the other one blank");
$sel->click_ok("create");
$sel->click_ok("link=Add an attachment");
$sel->wait_for_page_to_load_ok(WAIT_TIME);
$sel->title_is("Create New Attachment for Bug #$bug1_id");
-$sel->attach_file("data", $config->{attachment_file});
-$sel->type_ok("description", "patch, v4");
-$sel->value_is("ispatch", "on");
+$sel->attach_file('//input[@name="data"]', $config->{attachment_file});
+$sel->type_ok('//input[@name="description"]', "patch, v4");
+# This somehow fails with the current script but works when testing manually
+# $sel->value_is('//input[@name="ispatch"]', "on");
# canconfirm/editbugs privs are required to edit this flag.
$sel->type_ok("short_desc", "The selenium flag should be kept on product change");
$sel->type_ok("comment", "pom");
$sel->click_ok('//input[@value="Add an attachment"]');
-$sel->attach_file("data", $config->{attachment_file});
-$sel->type_ok("description", "small patch");
-$sel->value_is("ispatch", "on");
+$sel->attach_file('//input[@name="data"]', $config->{attachment_file});
+$sel->type_ok('//input[@name="description"]', "small patch");
+# This somehow fails with the current script but works when testing manually
+# $sel->value_is('//input[@name="ispatch"]', "on");
ok(!$sel->is_element_present("flag_type-$aflagtype1_id"), "Flag type $aflagtype1_id not available in TestProduct");
$sel->select_ok("flag_type-$aflagtype2_id", "label=-");
$sel->click_ok("commit");
$sel->type_ok("comment", "and some attachments too, like this one.");
$sel->check_ok("comment_is_private");
$sel->click_ok('//input[@value="Add an attachment"]');
-$sel->attach_file("data", $config->{attachment_file});
-$sel->type_ok("description", "private attachment, v1");
-$sel->check_ok("ispatch");
+$sel->attach_file('//input[@name="data"]', $config->{attachment_file});
+$sel->type_ok('//input[@name="description"]', "private attachment, v1");
+$sel->check_ok('//input[@name="ispatch"]');
$sel->click_ok("commit");
$sel->wait_for_page_to_load_ok(WAIT_TIME);
$sel->is_text_present_ok('has been added to the database', 'Bug created');
$sel->click_ok("link=Add an attachment");
$sel->wait_for_page_to_load_ok(WAIT_TIME);
$sel->title_is("Create New Attachment for Bug #$bug1_id");
-$sel->attach_file("data", $config->{attachment_file});
-$sel->type_ok("description", "public attachment, v2");
-$sel->check_ok("ispatch");
+$sel->attach_file('//input[@name="data"]', $config->{attachment_file});
+$sel->type_ok('//input[@name="description"]', "public attachment, v2");
+$sel->check_ok('//input[@name="ispatch"]');
# The existing attachment name must be displayed, to mark it as obsolete.
$sel->is_text_present_ok("private attachment, v1");
$sel->type_ok("comment", "this patch is public. Everyone can see it.");
$sel->click_ok("link=Add an attachment");
$sel->wait_for_page_to_load_ok(WAIT_TIME);
$sel->title_is("Create New Attachment for Bug #$bug1_id");
-$sel->attach_file("data", $config->{attachment_file});
-$sel->check_ok("ispatch");
+$sel->attach_file('//input[@name="data"]', $config->{attachment_file});
+$sel->check_ok('//input[@name="ispatch"]');
# The user doesn't have editbugs privs.
$sel->is_text_present_ok("[no attachments can be made obsolete]");
-$sel->type_ok("description", "My patch, which I should see, always");
+$sel->type_ok('//input[@name="description"]', "My patch, which I should see, always");
$sel->type_ok("comment", "This is my patch!");
$sel->click_ok("create");
$sel->wait_for_page_to_load_ok(WAIT_TIME);
my $bug_summary = "Security checks";
$sel->type_ok("short_desc", $bug_summary);
$sel->type_ok("comment", "This bug will be used to test security fixes.");
-$sel->attach_file("data", $config->{attachment_file});
-$sel->type_ok("description", "simple patch, v1");
+$sel->attach_file('//input[@name="data"]', $config->{attachment_file});
+$sel->type_ok('//input[@name="description"]', "simple patch, v1");
my $bug1_id = create_bug($sel, $bug_summary);
* Erik Stambaugh <erik@dasbistro.com>
* Marc Schumann <wurblzap@gmail.com>
* Guy Pyrzak <guy.pyrzak@gmail.com>
+ * Kohei Yoshino <kohei.yoshino@gmail.com>
*/
table.attachment_entry th {
text-align: right;
- vertical-align: baseline;
+ vertical-align: top;
white-space: nowrap;
}
font-size: small;
}
-#data-error {
- margin: 4px 0 0;
-}
-
-#data-error:empty {
- margin: 0;
-}
-
/* Rules used to view patches in diff mode. */
.file_head {
}
#attachment_info.edit #attachment_information_read_only {
- display: none;
+ display: none;
}
#attachment_info.edit #attachment_view_window {
#attachment_info.edit #attachment_information_edit input.text,
#attachment_info.edit #attachment_information_edit textarea {
- width: 90%;
+ width: 90%;
}
#attachment_isobsolete {
padding-right: 1em;
}
-#attachment_information_edit {
+#attachment_information_edit {
float: left;
}
}
#update {
- clear: both;
- display: block;
+ clear: both;
+ display: block;
}
div#update_container {
- clear: both;
- padding: 1.5em 0;
+ clear: both;
+ padding: 1.5em 0;
}
#attachment_flags {
}
#editFrame, #viewDiffFrame, #viewFrame {
- height: 400px;
+ height: 400px;
width: 95%;
margin-left: 2%;
overflow: auto;
}
#hidden_obsolete_message {
- text-align: left;
- width: 75%;
- margin: 0 auto;
+ text-align: left;
+ width: 75%;
+ margin: 0 auto;
font-weight: bold
}
-#description {
- resize: vertical;
+/**
+ * AttachmentForm
+ */
+
+#att-selector [hidden] {
+ display: none;
+}
+
+#att-selector label[role="button"] {
+ border-bottom: 1px solid #277AC1;
+ color: #277AC1;
+ cursor: pointer;
+ pointer-events: auto;
+}
+
+#att-selector .icon::before {
+ line-height: 100%;
+ font-family: FontAwesome;
+ font-style: normal;
+}
+
+#att-dropbox {
+ box-sizing: border-box;
+ border: 1px solid #999;
+ border-radius: 4px;
+ margin: 4px;
+ width: 560px;
+ background-color: #FFF;
+ -moz-user-select: none;
+ -webkit-user-select: none;
+ user-select: none;
+ transition: all .2s;
+}
+
+#att-dropbox.invalid {
+ border-color: #F33;
+ background-color: #FEE;
+ box-shadow: 0 0 4px #F33;
+}
+
+#att-dropbox.dragover {
+ border-color: #277AC1;
+ background-color: #DCE9F5;
+ box-shadow: 0 0 4px #277AC1;
+}
+
+#att-dropbox.invalid header,
+#att-dropbox.invalid #att-textarea,
+#att-dropbox.dragover header,
+#att-dropbox.dragover #att-textarea {
+ background-color: transparent;
+}
+
+#att-dropbox header {
+ display: flex;
+ align-items: center;
+ justify-content: center;
+ border-bottom: 1px solid #C0C0C0;
+ border-radius: 4px 4px 0 0;
+ padding: 8px;
+ font-size: 14px;
+ font-style: italic;
+ background-color: #F3F3F3;
+ pointer-events: none;
+ transition: all .2s;
+}
+
+#att-dropbox header .icon {
+ display: inline-block;
+ margin: 2px 8px 0 0;
+ color: #999;
+ transition: all .2s;
+}
+
+#att-dropbox.invalid header .icon {
+ color: #F33;
+}
+
+#att-dropbox.dragover header .icon {
+ color: #277AC1;
+}
+
+#att-dropbox .icon::before {
+ font-size: 24px;
+ content: "\F0EE";
+}
+
+#att-dropbox > div {
+ position: relative;
+ min-height: 160px;
+}
+
+#att-data {
+ display: none;
+ position: absolute;
+ bottom: 0;
+ left: 0;
+ z-index: -1;
+ outline: 0;
+ border: 0;
+ padding: 0;
+ width: 100%;
+ height: 100%;
+ box-shadow: none;
+ resize: none;
+}
+
+#att-data:invalid {
+ display: block; /* To display the validation message */
+}
+
+#att-textarea {
+ margin: 0;
+ border: 0;
+ border-radius: 0 0 4px 4px;
+ padding: 8px;
+ width: 100%;
+ height: 160px;
+ min-height: 160px;
+ font: 13px/1.2 "Droid Sans Mono", Menlo, Monaco, "Courier New", Courier, monospace;
+ white-space: pre;
+ resize: vertical;
+ transition: all .2s;
+}
+
+#att-preview {
+ display: flex;
+ align-items: center;
+ justify-content: center;
+ position: absolute;
+ top: 0;
+ right: 0;
+ bottom: 0;
+ left: 0;
+ border-radius: 0 0 4px 4px;
+ padding: 8px;
+ pointer-events: none;
+}
+
+#att-preview figure {
+ display: flex;
+ align-items: center;
+ justify-content: center;
+ position: absolute;
+ top: 0;
+ right: 0;
+ overflow: hidden;
+ margin: 0;
+ width: 100%;
+ height: 100%;
+ background-color: #EEE;
+}
+
+#att-preview [itemprop="name"] {
+ display: flex;
+ align-items: center;
+ justify-content: center;
+ position: absolute;
+ top: 0;
+ right: 0;
+ overflow: hidden;
+ box-sizing: border-box;
+ padding: 40px;
+ width: 100%;
+ height: 100%;
+ font-size: 14px;
+ text-align: center;
+ text-shadow: 0 0 4px #000;
+ color: #FFF;
+ background-image: linear-gradient(to bottom, transparent, rgba(0, 0, 0, .4));
+}
+
+#att-preview [itemprop="text"] {
+ position: absolute;
+ top: 0;
+ right: 0;
+ overflow: hidden;
+ box-sizing: border-box;
+ margin: 0;
+ padding: 8px;
+ width: 100%;
+ height: 100%;
+ font: 13px/1.2 "Droid Sans Mono", Menlo, Monaco, "Courier New", Courier, monospace;
+ color: #333;
+}
+
+#att-preview [itemprop="image"] {
+ max-width: 100%;
+}
+
+#att-preview [itemprop="text"]:empty,
+#att-preview [itemprop="text"]:not(:empty) ~ .icon,
+#att-preview [itemprop="image"][src=""],
+#att-preview [itemprop="image"]:not([src=""]) ~ .icon {
+ display: none;
+}
+
+#att-preview [itemprop="image"] ~ .icon::before {
+ font-size: 100px;
+ color: #999;
+ content: "\F15B";
+}
+
+#att-preview [itemprop="encodingFormat"][content="application/pdf"] ~ .icon::before {
+ content: "\F1C1";
+}
+
+#att-preview [itemprop="encodingFormat"][content="application/msword"] ~ .icon::before,
+#att-preview [itemprop="encodingFormat"][content*="wordprocessingml"] ~ .icon::before {
+ content: "\F1C2";
+}
+
+#att-preview [itemprop="encodingFormat"][content="application/vnd.ms-excel"] ~ .icon::before,
+#att-preview [itemprop="encodingFormat"][content*="spreadsheetml"] ~ .icon::before {
+ content: "\F1C3";
+}
+
+#att-preview [itemprop="encodingFormat"][content="application/vnd.ms-powerpoint"] ~ .icon::before,
+#att-preview [itemprop="encodingFormat"][content*="presentationml"] ~ .icon::before {
+ content: "\F1C4";
+}
+
+#att-preview [itemprop="encodingFormat"][content^="image/"] ~ .icon::before {
+ content: "\F1C5";
+}
+
+#att-preview [itemprop="encodingFormat"][content="application/zip"] ~ .icon::before,
+#att-preview [itemprop="encodingFormat"][content="application/x-bzip2"] ~ .icon::before,
+#att-preview [itemprop="encodingFormat"][content="application/x-gtar"] ~ .icon::before,
+#att-preview [itemprop="encodingFormat"][content="application/x-rar-compressed"] ~ .icon::before {
+ content: "\F1C6";
+}
+
+#att-preview [itemprop="encodingFormat"][content^="audio/"] ~ .icon::before {
+ content: "\F1C7";
+}
+
+#att-preview [itemprop="encodingFormat"][content^="video/"] ~ .icon::before {
+ content: "\F1C8";
+}
+
+#att-preview [itemprop="encodingFormat"][content^="text/"] ~ .icon::before {
+ content: "\F15C";
+}
+
+#att-remove-button {
+ display: flex;
+ align-items: center;
+ justify-content: center;
+ position: absolute;
+ top: 4px;
+ right: 4px;
+ padding: 4px;
+ pointer-events: auto;
+}
+
+#att-remove-button .icon::before {
+ font-size: 16px;
+ color: #666;
+ content: "\F057";
+}
+
+#att-error-message {
+ box-sizing: border-box;
+ margin: 8px 4px 0;
+ padding: 0 8px;
+ width: 560px;
+ text-align: center;
+ font-style: italic;
+}
+
+#att-error-message:empty {
+ margin: 0;
}
doc_section = "attachments.html"
%]
-<script [% script_nonce FILTER none %]>
-<!--
-TUI_hide_default('attachment_text_field');
--->
-</script>
-
[%# BMO hook for displaying MozReview message %]
[% Hook.process('before_form') %]
-<form name="entryform" method="post" action="attachment.cgi"
- enctype="multipart/form-data"
- onsubmit="return validateAttachmentForm(this)">
+<form name="entryform" method="post" action="attachment.cgi" enctype="multipart/form-data">
<input type="hidden" name="bugid" value="[% bug.bug_id %]">
<input type="hidden" name="action" value="insert">
<input type="hidden" name="token" value="[% token FILTER html %]">
<label for="takebug">take [% terms.bug %]</label>
[% bug_statuses = [] %]
[% FOREACH bug_status = bug.status.can_change_to %]
- [% NEXT IF bug_status.name == "UNCONFIRMED"
+ [% NEXT IF bug_status.name == "UNCONFIRMED"
&& !bug.product_obj.allows_unconfirmed %]
[% bug_statuses.push(bug_status) IF bug_status.is_open %]
[% END %]
# Joel Peshkin <bugreport@peshkin.net>
# Erik Stambaugh <erik@dasbistro.com>
# Marc Schumann <wurblzap@gmail.com>
+ # Kohei Yoshino <kohei.yoshino@gmail.com>
#%]
-<script [% script_nonce FILTER none %]>
- document.addEventListener("DOMContentLoaded", function (event) {
- document.querySelector("#attachment_data_controller").addEventListener(
- "click", function (event) {
- TUI_toggle_class('attachment_text_field');
- TUI_toggle_class('attachment_data');
- });
- });
-</script>
-
-<tr class="attachment_data">
- <th><label for="data">File</label>:</th>
+<tr id="att-selector">
+ <th class="required"><label for="att-file">File</label>:</th>
<td>
- <em>Enter the path to the file on your computer</em> (or
- <a id="attachment_data_controller">
- paste text as attachment</a>).<br>
- <input type="file" id="data" name="data" size="50" aria-errormessage="data-error" aria-invalid="false">
- <div id="data-error" class="warning" aria-live="assertive"><div>
- </td>
-</tr>
-<tr class="attachment_text_field">
- <th><label for="attach_text">File</label>:</th>
- <td>
- <em>Paste the text to be added as an attachment</em> (or
- <a id="attachment_text_field_controller" href="javascript:TUI_toggle_class('attachment_text_field');
- javascript:TUI_toggle_class('attachment_data')"
- >attach a file</a>).<br>
- <textarea id="attach_text" name="attach_text" cols="80" rows="15"
- onkeyup="TextFieldHandler()" onblur="TextFieldHandler()"></textarea>
+ <input hidden id="att-file" type="file" name="data" size="50">
+ <input id="att-filename" type="hidden" name="filename">
+ <section id="att-dropbox">
+ <header>
+ <span class="icon" aria-hidden="true"></span>
+ <span><label id="att-browse-label" tabindex="0" role="button">Browse a file</label>,
+ drag & drop it, or paste text/link/image below.</span>
+ </header>
+ <div>
+ <textarea hidden id="att-data" name="data_base64"
+ aria-errormessage="data-error" aria-invalid="false"></textarea>
+ <textarea id="att-textarea" name="attach_text" cols="80" rows="10"
+ aria-label="Paste the text, link or image to be added as an attachment"></textarea>
+ <div hidden id="att-preview">
+ <figure role="img" aria-labelledby="att-preview-name" itemscope itemtype="http://schema.org/MediaObject">
+ <meta itemprop="encodingFormat">
+ <pre itemprop="text"></pre>
+ <img src="" alt="" itemprop="image">
+ <figcaption id="att-preview-name" itemprop="name"></figcaption>
+ <span class="icon" aria-hidden="true"></span>
+ </figure>
+ <span id="att-remove-button" tabindex="0" role="button" aria-label="Remove attachment">
+ <span class="icon" aria-hidden="true"></span>
+ </span>
+ </div>
+ </div>
+ </section>
+ <div id="att-error-message" class="warning" aria-live="assertive"></div>
</td>
</tr>
<tr>
- <th class="required"><label for="description">Description</label>:</th>
+ <th class="required"><label for="att-description">Description</label>:</th>
<td>
<em>Describe the attachment briefly.</em><br>
- <input type="text" id="description" name="description" class="required"
- size="60" maxlength="200">
+ <input id="att-description" class="required" type="text" name="description" size="60" maxlength="200">
</td>
</tr>
<tr[% ' class="expert_fields"' UNLESS bug.id %]>
<td>
<em>If the attachment is a patch, check the box below.</em><br>
[% Hook.process("patch_notes") %]
- <input type="checkbox" id="ispatch" name="ispatch" value="1">
- <label for="ispatch">patch</label><br><br>
- [%# Reset this whenever the page loads so that the JS state is up to date %]
- <script [% script_nonce FILTER none %]>
- $(function() {
- $("#data").on("change", function() {
- DataFieldHandler();
- // Fire event to keep take-bug in sync.
- $("#ispatch").change();
- });
- $("#ispatch").on("change", function() {
- setContentTypeDisabledState(this.form);
- var takebug = $("#takebug");
- if (takebug.is(":visible") && takebug.data("take-if-patch") && $("#ispatch").prop("checked")) {
- $("#takebug").prop("checked", true);
- }
- }).change();
- });
- </script>
-
- <em>Otherwise, choose a method for determining the content type.</em><br>
- <input type="radio" id="autodetect"
- name="contenttypemethod" value="autodetect" checked="checked">
- <label for="autodetect">auto-detect</label><br>
- <input type="radio" id="list"
- name="contenttypemethod" value="list">
- <label for="list">select from list</label>:
- <select name="contenttypeselection" id="contenttypeselection"
- onchange="this.form.contenttypemethod[1].checked = true;">
- [% PROCESS content_types %]
- </select><br>
- <input type="radio" id="manual"
- name="contenttypemethod" value="manual">
- <label for="manual">enter manually</label>:
- <input type="text" name="contenttypeentry" id="contenttypeentry"
- size="30" maxlength="200"
- onchange="if (this.value) this.form.contenttypemethod[2].checked = true;">
+ <input id="att-ispatch" type="checkbox" name="ispatch">
+ <label for="att-ispatch">patch</label><br><br>
+ <div id="att-type-outer">
+ <em>Otherwise, choose a method for determining the content type.</em>
+ <div>
+ <input id="att-type-list" type="radio" name="contenttypemethod" value="list" checked>
+ <label for="att-type-list">select from list</label>:
+ <select id="att-type-select" name="contenttypeselection">[% PROCESS content_types %]</select>
+ </div>
+ <div>
+ <input id="att-type-manual" type="radio" name="contenttypemethod" value="manual">
+ <label for="att-type-manual">enter manually</label>:
+ <input id="att-type-input" type="text" name="contenttypeentry" size="30" maxlength="200">
+ </div>
+ </div>
</td>
</tr>
<tr[% ' class="expert_fields"' UNLESS bug.id %]>
showElementById('btn_no_attachment');
initCrashSignatureField();
init_take_handler('[% user.login FILTER js %]');
+ bz_attachment_form.update_requirements(false);
}
function initCrashSignatureField() {
// Hide the Advanced Fields by default, unless the user has a cookie
// that specifies otherwise.
TUI_hide_default('expert_fields');
-// Also hide the "Paste text as attachment" textarea by default.
-TUI_hide_default('attachment_text_field');
-->
</script>
},
string => {
# Please keep these in alphabetical order.
- attach_desc_required =>
- 'You must enter a Description for this attachment.',
component_required =>
"You must select a Component for this $terms.bug",
description_required =>
projects / thirdparty / bugzilla.git / commitdiff
