]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
evp_kdf_test: skip "engine" parameters when checking for updatability.
authorPauli <ppzgs1@gmail.com>
Wed, 2 Jul 2025 07:22:51 +0000 (17:22 +1000)
committerTomas Mraz <tomas@openssl.org>
Thu, 31 Jul 2025 18:21:25 +0000 (20:21 +0200)
The code already skips "properties" and "engines" behaves the same.

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/27923)

test/evp_kdf_test.c

index 898a170800e3e87e732c19e3e5744ac90e936a4f..a09470e28fb934d712801ec1a3c06fea65f47baf 100644 (file)
@@ -2072,9 +2072,14 @@ static int test_kdf_hmac_drbg_settables(void)
     /* Fail if we pass the wrong type for params */
     params[1] = OSSL_PARAM_construct_end();
     for (i = 0; settableparams[i].key != NULL; ++i) {
-        /* Skip "properties" key since it returns 1 unless the digest is also set */
+        /*
+         * Skip "properties" and "engine" keys since they returns 1 unless
+         * the digest is also set
+         */
         if (OPENSSL_strcasecmp(settableparams[i].key,
-                               OSSL_KDF_PARAM_PROPERTIES) != 0) {
+                               OSSL_KDF_PARAM_PROPERTIES) != 0
+                && OPENSSL_strcasecmp(settableparams[i].key,
+                               OSSL_ALG_PARAM_ENGINE) != 0) {
             TEST_note("Testing set int into %s fails", settableparams[i].key);
             params[0] = OSSL_PARAM_construct_int(settableparams[i].key, &j);
             if (!TEST_int_le(EVP_KDF_CTX_set_params(kctx, params), 0))