]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: wl1251: Use IRQF_NO_AUTOEN flag in request_irq()
authorJinjie Ruan <ruanjinjie@huawei.com>
Tue, 10 Sep 2024 12:43:14 +0000 (20:43 +0800)
committerKalle Valo <kvalo@kernel.org>
Wed, 18 Sep 2024 13:54:30 +0000 (16:54 +0300)
As commit cbe16f35bee6 ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()")
said, the code below is subobtimal. IRQF_NO_AUTOEN flag can be used by
drivers to request_irq(). It prevents the automatic enabling of the
requested interrupt in the same safe way. With that the usage can be
simplified and corrected.

irq_set_status_flags(irq, IRQ_NOAUTOEN);
request_irq(dev, irq...);

Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/20240910124314.698896-4-ruanjinjie@huawei.com
drivers/net/wireless/ti/wl1251/sdio.c

index c705081249d697625d894cf2ba3dbb7acb29ed7c..b45050243129161fe257dd7e3e42c81f95498989 100644 (file)
@@ -233,8 +233,8 @@ static int wl1251_sdio_probe(struct sdio_func *func,
        }
 
        if (wl->irq) {
-               irq_set_status_flags(wl->irq, IRQ_NOAUTOEN);
-               ret = request_irq(wl->irq, wl1251_line_irq, 0, "wl1251", wl);
+               ret = request_irq(wl->irq, wl1251_line_irq, IRQF_NO_AUTOEN,
+                                 "wl1251", wl);
                if (ret < 0) {
                        wl1251_error("request_irq() failed: %d", ret);
                        goto disable;