]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
sched/fair: Remove unused parameter from sched_asym()
authorAlex Shi <alexs@kernel.org>
Sat, 10 Feb 2024 11:39:20 +0000 (19:39 +0800)
committerIngo Molnar <mingo@kernel.org>
Wed, 28 Feb 2024 14:43:08 +0000 (15:43 +0100)
The 'sds' argument is not used in the sched_asym() function anymore, remove it.

Fixes: c9ca07886aaa ("sched/fair: Do not even the number of busy CPUs via asym_packing")
Signed-off-by: Alex Shi <alexs@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Reviewed-by: Valentin Schneider <vschneid@redhat.com>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Link: https://lore.kernel.org/r/20240210113924.1130448-2-alexs@kernel.org
kernel/sched/fair.c

index 51fe17f10ef8879ff5a3270d6402824100abf827..300d1bfe6d2bfbaa549f37667f93cf693f920620 100644 (file)
@@ -9753,7 +9753,6 @@ static bool sched_use_asym_prio(struct sched_domain *sd, int cpu)
 /**
  * sched_asym - Check if the destination CPU can do asym_packing load balance
  * @env:       The load balancing environment
- * @sds:       Load-balancing data with statistics of the local group
  * @sgs:       Load-balancing statistics of the candidate busiest group
  * @group:     The candidate busiest group
  *
@@ -9772,8 +9771,7 @@ static bool sched_use_asym_prio(struct sched_domain *sd, int cpu)
  * otherwise.
  */
 static inline bool
-sched_asym(struct lb_env *env, struct sd_lb_stats *sds,  struct sg_lb_stats *sgs,
-          struct sched_group *group)
+sched_asym(struct lb_env *env, struct sg_lb_stats *sgs, struct sched_group *group)
 {
        /* Ensure that the whole local core is idle, if applicable. */
        if (!sched_use_asym_prio(env->sd, env->dst_cpu))
@@ -9944,7 +9942,7 @@ static inline void update_sg_lb_stats(struct lb_env *env,
        /* Check if dst CPU is idle and preferred to this group */
        if (!local_group && env->sd->flags & SD_ASYM_PACKING &&
            env->idle != CPU_NOT_IDLE && sgs->sum_h_nr_running &&
-           sched_asym(env, sds, sgs, group)) {
+           sched_asym(env, sgs, group)) {
                sgs->group_asym_packing = 1;
        }