]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
clk: sophgo: clk-sg2042-pll: Fix uninitialized variable in debug output
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 18 Jul 2024 02:25:53 +0000 (21:25 -0500)
committerStephen Boyd <sboyd@kernel.org>
Thu, 18 Jul 2024 20:33:15 +0000 (13:33 -0700)
If sg2042_get_pll_ctl_setting() fails then "value" isn't initialized and
it is printed in the debug output.  Initialize it to zero.

Fixes: 48cf7e01386e ("clk: sophgo: Add SG2042 clock driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/baf0a490-d5ba-4528-90ba-80399684692d@stanley.mountain
Reviewed-by: Chen Wang <unicorn_wang@outlook.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/sophgo/clk-sg2042-pll.c

index 9695e64fc23b975721f7ed01f00473e53039b8a6..ff9deeef509b8f1d6a565094e48285d59a54cccb 100644 (file)
@@ -387,7 +387,7 @@ static int sg2042_clk_pll_set_rate(struct clk_hw *hw,
        struct sg2042_pll_clock *pll = to_sg2042_pll_clk(hw);
        struct sg2042_pll_ctrl pctrl_table;
        unsigned long flags;
-       u32 value;
+       u32 value = 0;
        int ret;
 
        spin_lock_irqsave(pll->lock, flags);