]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
PCI: keystone: Set mode as Root Complex for "ti,keystone-pcie" compatible
authorKishon Vijay Abraham I <kishon@ti.com>
Fri, 24 May 2024 10:57:13 +0000 (16:27 +0530)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Thu, 7 Nov 2024 15:35:17 +0000 (15:35 +0000)
commit 23284ad677a9 ("PCI: keystone: Add support for PCIe EP in AM654x
Platforms") introduced configuring "enum dw_pcie_device_mode" as part of
device data ("struct ks_pcie_of_data"). However it failed to set the
mode for "ti,keystone-pcie" compatible.

Since the mode defaults to "DW_PCIE_UNKNOWN_TYPE", the following error
message is displayed for the v3.65a controller:

  "INVALID device type 0"

Despite the driver probing successfully, the controller may not be
functional in the Root Complex mode of operation.

So, set the mode as Root Complex for "ti,keystone-pcie" compatible to
fix this.

Fixes: 23284ad677a9 ("PCI: keystone: Add support for PCIe EP in AM654x Platforms")
Link: https://lore.kernel.org/r/20240524105714.191642-2-s-vadapalli@ti.com
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
[kwilczynski: commit log, added tag for stable releases]
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Cc: stable@vger.kernel.org
drivers/pci/controller/dwc/pci-keystone.c

index 2219b1a866faf2d7b13e2d4c450a48f6697e0e41..b99bc4071fe9260d2d3117ba33a86a974dad6ff9 100644 (file)
@@ -1093,6 +1093,7 @@ static int ks_pcie_am654_set_mode(struct device *dev,
 
 static const struct ks_pcie_of_data ks_pcie_rc_of_data = {
        .host_ops = &ks_pcie_host_ops,
+       .mode = DW_PCIE_RC_TYPE,
        .version = DW_PCIE_VER_365A,
 };