]> git.ipfire.org Git - thirdparty/freeswitch.git/commitdiff
[core] Fix read of uninitialized buffer in switch_simple_email(). 1199/head
authorChris Rienzo <chris@signalwire.com>
Sun, 16 May 2021 23:12:28 +0000 (23:12 +0000)
committerChris Rienzo <chris@signalwire.com>
Sun, 16 May 2021 23:12:54 +0000 (23:12 +0000)
src/switch_utils.c

index 0fee81551b2564f65e8dda58bc3ef2f5bfad0bc6..85e12f0488131969bfbaaa1ea31a4d4713ff8be0 100644 (file)
@@ -1128,6 +1128,8 @@ SWITCH_DECLARE(switch_bool_t) switch_simple_email(const char *to,
        switch_bool_t rval = SWITCH_FALSE;
        const char *err = NULL;
 
+       filename[0] = '\0';
+
        if (zstr(to)) {
                err = "No to address specified";
                goto end;
@@ -1323,7 +1325,7 @@ SWITCH_DECLARE(switch_bool_t) switch_simple_email(const char *to,
                close(fd);
        }
 
-       if (unlink(filename) != 0) {
+       if (!zstr_buf(filename) && unlink(filename) != 0) {
                switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_WARNING, "Failed to delete file [%s]\n", filename);
        }