]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
usb: dwc2: Add missing null check
authorAndrew Goodbody <andrew.goodbody@linaro.org>
Mon, 29 Sep 2025 16:40:43 +0000 (17:40 +0100)
committerMattijs Korpershoek <mkorpershoek@kernel.org>
Tue, 30 Sep 2025 09:53:10 +0000 (11:53 +0200)
Add in the missing null check for dev->driver that is present at other
points in the function before it is dereferenced.

This issue was found by Smatch.

Signed-off-by: Andrew Goodbody <andrew.goodbody@linaro.org>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
Reviewed-by: Marek Vasut <marek.vasut@mailbox.org>
Link: https://lore.kernel.org/r/20250929-usb_dwc2-v1-1-863133dcbcde@linaro.org
Signed-off-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c

index fca052b4556a7d2ae4fe516e39820611d7082e2f..5a7f50ebaa5579f67ea5dc9491d0d1f4d4b81ea1 100644 (file)
@@ -526,7 +526,7 @@ static int dwc2_udc_irq(int irq, void *_dev)
                if (gotgint & GOTGINT_SES_END_DET) {
                        debug_cond(DEBUG_ISR, "\t\tSession End Detected\n");
                        /* Let gadget detect disconnected state */
-                       if (dev->driver->disconnect) {
+                       if (dev->driver && dev->driver->disconnect) {
                                spin_unlock_irqrestore(&dev->lock, flags);
                                dev->driver->disconnect(&dev->gadget);
                                spin_lock_irqsave(&dev->lock, flags);