Get rid of WANT_FLOAT128 usage in floatn.h

This header is installed system-wide. It's not correct to introduce a new
macro WANT_FLOAT128 in this because then we are either forcing the compiler to
make it an inbuilt macro to make glibc expose all float128 functionality, or asking
our clients to -DWANT_FLOAT128 to get float128 functionality in glibc.

Given we are primarily going to have float128 enabled GRTE now, we don't need to have
guards for non-float128 cases.

diff --git a/Makefile b/Makefile
index 084fec33317798f1f2f11780d79f78288288a99c..bea4e27f8db4981dbd0eb39e06b4f6297cb5179d 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -252,10 +252,6 @@ mostlyclean: parent-mostlyclean
 tests-clean:
        @$(MAKE) subdir_testclean no_deps=t
 
-ifeq ($(enable-float128),yes)
-CPPFLAGS += -DWANT_FLOAT128=1
-endif
-
 ifneq (,$(CXX))
 vpath c++-types.data $(+sysdep_dirs)
 

diff --git a/math/Makefile b/math/Makefile
index 6ad3ccea2000d68f363ba4a079ef4ea7697505c9..ec7d91ca3d755498fc8e72ff9a9e03159c723675 100644 (file)
--- a/math/Makefile
+++ b/math/Makefile
@@ -160,10 +160,6 @@ gen-calls = s_ldexpF
 generated += $(foreach s,.c .S,$(call type-foreach, $(calls:s_%=m_%$(s))))
 routines = $(call type-foreach, $(calls))
 
-ifeq ($(enable-float128),yes)
-math-CPPFLAGS += -DWANT_FLOAT128=1
-endif
-
 ifeq ($(build-mathvec),yes)
 # We need to install libm.so and libm.a as linker scripts
 # for transparent use of vector math library.

diff --git a/sysdeps/x86/bits/floatn.h b/sysdeps/x86/bits/floatn.h
index 9dd9d8a40d61a13c78e2c5d5a2ad56f9d511b649..7387bbae38f5ab3e0af355425e7932b70010ebbd 100644 (file)
--- a/sysdeps/x86/bits/floatn.h
+++ b/sysdeps/x86/bits/floatn.h
@@ -33,7 +33,7 @@
 #if (defined __x86_64__                                                        \
      ? __GNUC_PREREQ (4, 3)                                            \
      : (defined __GNU__ ? __GNUC_PREREQ (4, 5) : __GNUC_PREREQ (4, 4))) \
-    || (defined __clang__ && defined WANT_FLOAT128 && WANT_FLOAT128 == 1)
+    || defined __clang__
 # define __HAVE_FLOAT128 1
 #else
 # define __HAVE_FLOAT128 0