]> git.ipfire.org Git - thirdparty/git.git/commitdiff
update-ref: drop unused argument for `parse_refname`
authorPatrick Steinhardt <ps@pks.im>
Thu, 2 Apr 2020 07:09:43 +0000 (09:09 +0200)
committerJunio C Hamano <gitster@pobox.com>
Thu, 2 Apr 2020 18:09:48 +0000 (11:09 -0700)
The `parse_refname` function accepts a `struct strbuf *input` argument
that isn't used at all. As we're about to convert commands to not use a
strbuf anymore but instead an end pointer, let's drop this argument now
to make the converting commit easier to review.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/update-ref.c

index a6ff88b95b1ee5ce0bb6acfade1fea786aa2ba2c..1bba5ea6c20652af1664ad87c6ccecb7e25fd94a 100644 (file)
@@ -50,7 +50,7 @@ static const char *parse_arg(const char *next, struct strbuf *arg)
  * the argument.  Die if C-quoting is malformed or the reference name
  * is invalid.
  */
-static char *parse_refname(struct strbuf *input, const char **next)
+static char *parse_refname(const char **next)
 {
        struct strbuf ref = STRBUF_INIT;
 
@@ -186,7 +186,7 @@ static const char *parse_cmd_update(struct ref_transaction *transaction,
        struct object_id new_oid, old_oid;
        int have_old;
 
-       refname = parse_refname(input, &next);
+       refname = parse_refname(&next);
        if (!refname)
                die("update: missing <ref>");
 
@@ -220,7 +220,7 @@ static const char *parse_cmd_create(struct ref_transaction *transaction,
        char *refname;
        struct object_id new_oid;
 
-       refname = parse_refname(input, &next);
+       refname = parse_refname(&next);
        if (!refname)
                die("create: missing <ref>");
 
@@ -253,7 +253,7 @@ static const char *parse_cmd_delete(struct ref_transaction *transaction,
        struct object_id old_oid;
        int have_old;
 
-       refname = parse_refname(input, &next);
+       refname = parse_refname(&next);
        if (!refname)
                die("delete: missing <ref>");
 
@@ -288,7 +288,7 @@ static const char *parse_cmd_verify(struct ref_transaction *transaction,
        char *refname;
        struct object_id old_oid;
 
-       refname = parse_refname(input, &next);
+       refname = parse_refname(&next);
        if (!refname)
                die("verify: missing <ref>");