Bug 147486 - First (of many?) fixes of cross site scripting issues; checked in on...

diff --git a/editusers.cgi b/editusers.cgi
index cc56966d7fb4990d6a98abcd875f70c2e1d52884..2db93e4acc4d68457e86193efb9b5a3ebfd73c28 100755 (executable)
--- a/editusers.cgi
+++ b/editusers.cgi
@@ -336,7 +336,7 @@ if ($action eq 'list') {
             $s = "<STRIKE>";
             $e = "</STRIKE>";
         }
-       $realname ||= "<FONT COLOR=\"red\">missing</FONT>";
+       $realname = ($realname ? html_quote($realname) : "<FONT COLOR=\"red\">missing</FONT>");
        print "<TR>\n";
        print "  <TD VALIGN=\"top\"><A HREF=\"editusers.cgi?action=edit&user=", url_quote($user), "\"><B>$s$user$e</B></A></TD>\n";
        print "  <TD VALIGN=\"top\">$s$realname$e</TD>\n";
@@ -535,7 +535,7 @@ if ($action eq 'del') {
             WHERE login_name=" . SqlQuote($user));
     my ($realname, $groupset) = 
       FetchSQLData();
-    $realname ||= "<FONT COLOR=\"red\">missing</FONT>";
+    $realname = ($realname ? html_quote($realname) : "<FONT COLOR=\"red\">missing</FONT>");
     
     print "<TABLE BORDER=1 CELLPADDING=4 CELLSPACING=0>\n";
     print "<TR BGCOLOR=\"#6666FF\">\n";