]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Bug 3078: crashes repeatedly after rebuilding the cache
authorAmos Jeffries <squid3@treenet.co.nz>
Mon, 18 Oct 2010 11:49:19 +0000 (00:49 +1300)
committerAmos Jeffries <squid3@treenet.co.nz>
Mon, 18 Oct 2010 11:49:19 +0000 (00:49 +1300)
Regression from must-revalidate HTTP/1.1 compliance fixes.
Only flag refresh/revalidation failure when client request is present.

src/refresh.cc

index dbf6c2e1071f63589cc366307cb738638b0340f6..b977e226bdbcb61a13d964df7e79e068ca30d134 100644 (file)
@@ -289,7 +289,8 @@ refreshCheck(const StoreEntry * entry, HttpRequest * request, time_t delta)
 #endif
        ) {
         debugs(22, 3, "refreshCheck: YES: Must revalidate stale response");
-        request->flags.fail_on_validation_err = 1;
+        if (request)
+            request->flags.fail_on_validation_err = 1;
         return STALE_MUST_REVALIDATE;
     }