]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/qxl: lost qxl_bo_kunmap_atomic_page in qxl_image_init_helper()
authorVasily Averin <vvs@virtuozzo.com>
Wed, 29 Apr 2020 09:34:36 +0000 (12:34 +0300)
committerGerd Hoffmann <kraxel@redhat.com>
Wed, 29 Apr 2020 11:21:34 +0000 (13:21 +0200)
v2: removed TODO reminder

Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Link: http://patchwork.freedesktop.org/patch/msgid/a4e0ae09-a73c-1c62-04ef-3f990d41bea9@virtuozzo.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
drivers/gpu/drm/qxl/qxl_image.c

index 43688ecdd8a04d9d4bc3286ae03259c9892626e8..60ab7151b84dce9a2d2d4aa9837345fde2951c5a 100644 (file)
@@ -212,7 +212,8 @@ qxl_image_init_helper(struct qxl_device *qdev,
                break;
        default:
                DRM_ERROR("unsupported image bit depth\n");
-               return -EINVAL; /* TODO: cleanup */
+               qxl_bo_kunmap_atomic_page(qdev, image_bo, ptr);
+               return -EINVAL;
        }
        image->u.bitmap.flags = QXL_BITMAP_TOP_DOWN;
        image->u.bitmap.x = width;