]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
Avoid possible signed overflow in decode_local_label_name
authorAlan Modra <amodra@gmail.com>
Mon, 1 Jul 2024 14:32:33 +0000 (00:02 +0930)
committerAlan Modra <amodra@gmail.com>
Wed, 3 Jul 2024 06:07:35 +0000 (15:37 +0930)
Matches what both fb_label_name and dollar_label_name use.

* symbols.c (decode_local_label_name): Use unsigned variables.

gas/symbols.c

index b57dbfc64f42e131ebb501bccfcea3676bf80cfc..fa3aaa37ed4691c3b6e7cd40a3b09d5c7479dbe5 100644 (file)
@@ -2185,11 +2185,11 @@ decode_local_label_name (char *s)
 {
   char *p;
   char *symbol_decode;
-  int label_number;
-  int instance_number;
+  unsigned int label_number;
+  unsigned int instance_number;
   const char *type;
   const char *message_format;
-  int lindex = 0;
+  unsigned int lindex = 0;
 
 #ifdef LOCAL_LABEL_PREFIX
   if (s[lindex] == LOCAL_LABEL_PREFIX)
@@ -2212,7 +2212,7 @@ decode_local_label_name (char *s)
   for (instance_number = 0, p++; ISDIGIT (*p); ++p)
     instance_number = (10 * instance_number) + *p - '0';
 
-  message_format = _("\"%d\" (instance number %d of a %s label)");
+  message_format = _("\"%u\" (instance number %u of a %s label)");
   symbol_decode = notes_alloc (strlen (message_format) + 30);
   sprintf (symbol_decode, message_format, label_number, instance_number, type);