]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
BUG/MINOR: quic: Dropped peer transport parameters
authorFrédéric Lécaille <flecaille@haproxy.com>
Tue, 3 May 2022 13:55:17 +0000 (15:55 +0200)
committerFrédéric Lécaille <flecaille@haproxy.com>
Thu, 12 May 2022 13:26:10 +0000 (15:26 +0200)
The call to quic_dflt_transport_params_cpy() is already first done by
quic_transport_params_init() which is a good thing. But this function was also
called each time we parsed a transport parameters with quic_transport_param_decode(),
re-initializing to default values some of them. The transport parameters concerned
by this bug are the following:
   - max_udp_payload_size
   - ack_delay_exponent
   - max_ack_delay
   - active_connection_id_limit
So, let's remove this call to quic_dflt_transport_params_cpy() which has nothing
to do here!

include/haproxy/xprt_quic.h

index a61af090c34a9a949cb7a22ccd29dbe84bdcb0e3..6ff29b4cd5a828a46bb3114712004cf663d8a712 100644 (file)
@@ -607,7 +607,6 @@ static inline int quic_transport_param_decode(struct quic_transport_params *p,
 {
        const unsigned char *end = *buf + len;
 
-       quic_dflt_transport_params_cpy(p);
        switch (type) {
        case QUIC_TP_ORIGINAL_DESTINATION_CONNECTION_ID:
                if (!server || len >= sizeof p->original_destination_connection_id.data)