]> git.ipfire.org Git - people/ms/gcc.git/commitdiff
typecheck: Add basic typechecking for ReferenceType
authorgoar5670 <mahadelr19@gmail.com>
Mon, 6 Mar 2023 22:25:39 +0000 (01:25 +0300)
committerPhilip Herron <philip.herron@embecosm.com>
Wed, 8 Mar 2023 10:26:22 +0000 (10:26 +0000)
gcc/rust/ChangeLog:
* hir/tree/rust-hir-pattern.h (HIR::ReferencePattern):
added get_referenced_pattern function.
* resolve/rust-ast-resolve-pattern.h
(Resolve::PatternDeclaration): add visit function for
AST::ReferencePattern
* typecheck/rust-hir-type-check-pattern.cc
(Resolver::TypeCheckPattern): add visit function for
HIR::ReferencePattern

gcc/testsuite/ChangeLog:
* rust/compile/ref_pattern_fn_param.rs: New test.

Signed-off-by: Mahmoud Mohamed <mahadelr19@gmail.com>
gcc/rust/hir/tree/rust-hir-pattern.h
gcc/rust/resolve/rust-ast-resolve-pattern.h
gcc/rust/typecheck/rust-hir-type-check-pattern.cc
gcc/testsuite/rust/compile/ref_pattern_fn_param.rs [new file with mode: 0644]

index 69faed1643e597f01a8ff7a8cb3efa9bacb70cc6..63725fa79d843ce2b1e3784f6a7aa403afd94506 100644 (file)
@@ -477,6 +477,12 @@ public:
     return PatternType::REFERENCE;
   }
 
+  std::unique_ptr<Pattern> &get_referenced_pattern ()
+  {
+    rust_assert (pattern != nullptr);
+    return pattern;
+  }
+
 protected:
   /* Use covariance to implement clone function as returning this object rather
    * than base */
index 4c7d13a16d06a9df2f6034551151a40b8c856e29..12d2b5986e80d1a26818a9537b4d3826d429179f 100644 (file)
@@ -75,6 +75,11 @@ public:
     pattern.get_pattern_in_parens ()->accept_vis (*this);
   }
 
+  void visit (AST::ReferencePattern &pattern) override
+  {
+    pattern.get_referenced_pattern ()->accept_vis (*this);
+  }
+
   // cases in a match expression
   void visit (AST::PathInExpression &pattern) override;
 
index 3dca07baf9cac2b8b111640052a2cd663759d1c2..e7ed54250a079b7b33a37dd80a392aee1b65654c 100644 (file)
@@ -410,8 +410,13 @@ TypeCheckPattern::visit (HIR::QualifiedPathInExpression &pattern)
 void
 TypeCheckPattern::visit (HIR::ReferencePattern &pattern)
 {
-  rust_sorry_at (pattern.get_locus (),
-                "type checking qualified path patterns not supported");
+  if (parent->get_kind () != TyTy::TypeKind::REF)
+    rust_error_at (pattern.get_locus (), "expected %s, found reference",
+                  parent->as_string ().c_str ());
+
+  TyTy::ReferenceType *ref_ty_ty = static_cast<TyTy::ReferenceType *> (parent);
+  TypeCheckPattern::Resolve (pattern.get_referenced_pattern ().get (),
+                            ref_ty_ty->get_base ());
 }
 
 void
diff --git a/gcc/testsuite/rust/compile/ref_pattern_fn_param.rs b/gcc/testsuite/rust/compile/ref_pattern_fn_param.rs
new file mode 100644 (file)
index 0000000..67ea033
--- /dev/null
@@ -0,0 +1 @@
+fn f(&b: i32) {} // { dg-error "expected i32, found reference" }