]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
ctdbd_conn: use the right error code from ctdbd_connect for debug and return
authorMichael Adam <obnox@samba.org>
Fri, 26 Jun 2015 11:17:01 +0000 (13:17 +0200)
committerGünther Deschner <gd@samba.org>
Fri, 26 Jun 2015 15:21:26 +0000 (17:21 +0200)
ctdbd_connect() explicitly returns the errno.
Using errno instead of ret misses some important
manually set return values and might use the
errno that is changed by close(fd).

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Fri Jun 26 17:21:26 CEST 2015 on sn-devel-104

source3/lib/ctdbd_conn.c

index 962ab4347435215fcd464f5cbe71127051b089bf..fae086a2be6b6cc78a5fad1cd57a83e83462218a 100644 (file)
@@ -458,8 +458,8 @@ static NTSTATUS ctdbd_init_connection(TALLOC_CTX *mem_ctx,
 
        ret = ctdbd_connect(&conn->fd);
        if (ret != 0) {
-               status = map_nt_error_from_unix(errno);
-               DEBUG(1, ("ctdbd_connect failed: %s\n", strerror(errno)));
+               status = map_nt_error_from_unix(ret);
+               DEBUG(1, ("ctdbd_connect failed: %s\n", strerror(ret)));
                goto fail;
        }
        talloc_set_destructor(conn, ctdbd_connection_destructor);