]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
libstdc++: Test error handling in std::print
authorJonathan Wakely <jwakely@redhat.com>
Thu, 22 Feb 2024 13:06:59 +0000 (13:06 +0000)
committerJonathan Wakely <jwakely@redhat.com>
Wed, 28 Feb 2024 11:27:46 +0000 (11:27 +0000)
The standard requires an exception if std::print fails to write to a
FILE*. When writing to a std::ostream, failure to format the arguments
doesn't affect the stream state, but failure to write to the streadm
sets badbit.

libstdc++-v3/ChangeLog:

* testsuite/27_io/basic_ostream/print/1.cc: Check error
handling.
* testsuite/27_io/print/1.cc: Likewise.

libstdc++-v3/testsuite/27_io/basic_ostream/print/1.cc
libstdc++-v3/testsuite/27_io/print/1.cc

index 71a4daa04c90e0e293715a36cd1e11b994860cb1..cd4b116ac1c0c08ae55794ec7d5b009945eb21d5 100644 (file)
@@ -103,6 +103,40 @@ test_locale()
   }
 }
 
+void
+test_errors()
+{
+  // Failure to generate output is reported by setting badbit.
+  std::stringstream in(std::ios::in);
+  std::print(in, "{}", "nope"); // No exception here.
+  VERIFY(in.bad());
+#ifdef __cpp_exceptions
+  in.clear();
+  in.exceptions(std::ios::badbit);
+  try
+  {
+    std::print(in, "{}", "nope"); // Should throw now.
+    VERIFY(false);
+  }
+  catch (const std::ios::failure&)
+  {
+  }
+
+  // An exception thrown when formatting the string is propagated
+  // without setting badbit.
+  std::ostringstream out;
+  try
+  {
+    std::vprint_nonunicode(out, "{}", std::make_format_args());
+    VERIFY(false);
+  }
+  catch (const std::format_error&)
+  {
+  }
+  VERIFY(out.good());
+#endif
+}
+
 int main()
 {
   test_print_ostream();
@@ -111,4 +145,5 @@ int main()
   test_print_no_padding();
   test_vprint_nonunicode();
   test_locale();
+  test_errors();
 }
index 6a294e0454b7b8364a37069e8beb4716155fae0a..d570f7938be657c98c50cb3f0a0296bf269ae5e1 100644 (file)
@@ -74,6 +74,21 @@ test_vprint_nonunicode()
   // { dg-output "garbage in . garbage out" }
 }
 
+void
+test_errors()
+{
+#ifdef __cpp_exceptions
+  try
+  {
+    std::print(stdin, "{}", "nope");
+    VERIFY(false);
+  }
+  catch (const std::system_error&)
+  {
+  }
+#endif
+}
+
 int main()
 {
   test_print_default();
@@ -82,4 +97,5 @@ int main()
   test_println_file();
   test_print_raw();
   test_vprint_nonunicode();
+  test_errors();
 }