]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
hw/smbios: add stub for smbios_get_table_legacy()
authorIgor Mammedov <imammedo@redhat.com>
Tue, 26 Mar 2024 12:26:30 +0000 (13:26 +0100)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Tue, 26 Mar 2024 13:32:54 +0000 (14:32 +0100)
QEMU build fails with

  hw/i386/fw_cfg.c:74: undefined reference to `smbios_get_table_legacy'

when it's built with only 'microvm' enabled i.e. with config patch

   +++ b/configs/devices/i386-softmmu/default.mak
   @@ -26,7 +26,7 @@

   # Boards:
   #
   -CONFIG_ISAPC=y
   -CONFIG_I440FX=y
   -CONFIG_Q35=y
   +CONFIG_ISAPC=n
   +CONFIG_I440FX=n
   +CONFIG_Q35=n

It happens because I've fogotten/lost smbios_get_table_legacy() stub.

Fix it by adding missing stub as Philippe suggested.

Fixes: b42b0e4daaa5 "smbios: build legacy mode code only for 'pc' machine"
Reported-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20240326122630.85989-1-imammedo@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
hw/smbios/smbios_legacy_stub.c

index f29b15316ce25149655b9571d4cc331bbc86c35e..7d593dca98642a2c7bfe5845cf00cb3ca0780ad6 100644 (file)
@@ -13,3 +13,8 @@
 void smbios_add_usr_blob_size(size_t size)
 {
 }
+
+uint8_t *smbios_get_table_legacy(size_t *length, Error **errp)
+{
+    g_assert_not_reached();
+}