]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
[range-ops] Handle bitmasks for unary operators.
authorAldy Hernandez <aldyh@redhat.com>
Tue, 25 Jul 2023 16:30:42 +0000 (12:30 -0400)
committerAldy Hernandez <aldyh@redhat.com>
Wed, 26 Jul 2023 08:38:37 +0000 (10:38 +0200)
It looks like we missed out on bitmasks for unary operators because we
were using bit_value_binop exclusively.  This patch hands off to
bit_value_unop when appropriate, thus allowing us to handle ABS and
BIT_NOT_EXPR, and others.  Follow-up patches will add the tweaks for the
range-ops entries themselves.

gcc/ChangeLog:

* range-op.cc (update_known_bitmask): Handle unary operators.

gcc/range-op.cc

index 6b5d4f2accd29e826348c3066bb2594462b0f084..d959a3e93dce81cd0d8832bde4f8082e64e8be1b 100644 (file)
@@ -385,15 +385,29 @@ update_known_bitmask (irange &r, tree_code code,
   irange_bitmask lh_bits = lh.get_bitmask ();
   irange_bitmask rh_bits = rh.get_bitmask ();
 
-  bit_value_binop (code, sign, prec, &widest_value, &widest_mask,
-                  TYPE_SIGN (lh.type ()),
-                  TYPE_PRECISION (lh.type ()),
-                  widest_int::from (lh_bits.value (), sign),
-                  widest_int::from (lh_bits.mask (), sign),
-                  TYPE_SIGN (rh.type ()),
-                  TYPE_PRECISION (rh.type ()),
-                  widest_int::from (rh_bits.value (), sign),
-                  widest_int::from (rh_bits.mask (), sign));
+  switch (get_gimple_rhs_class (code))
+    {
+    case GIMPLE_UNARY_RHS:
+      bit_value_unop (code, sign, prec, &widest_value, &widest_mask,
+                     TYPE_SIGN (lh.type ()),
+                     TYPE_PRECISION (lh.type ()),
+                     widest_int::from (lh_bits.value (), sign),
+                     widest_int::from (lh_bits.mask (), sign));
+      break;
+    case GIMPLE_BINARY_RHS:
+      bit_value_binop (code, sign, prec, &widest_value, &widest_mask,
+                      TYPE_SIGN (lh.type ()),
+                      TYPE_PRECISION (lh.type ()),
+                      widest_int::from (lh_bits.value (), sign),
+                      widest_int::from (lh_bits.mask (), sign),
+                      TYPE_SIGN (rh.type ()),
+                      TYPE_PRECISION (rh.type ()),
+                      widest_int::from (rh_bits.value (), sign),
+                      widest_int::from (rh_bits.mask (), sign));
+      break;
+    default:
+      gcc_unreachable ();
+    }
 
   wide_int mask = wide_int::from (widest_mask, prec, sign);
   wide_int value = wide_int::from (widest_value, prec, sign);