]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
perf report: Add s390 diagnosic sampling descriptor size
authorThomas Richter <tmricht@linux.ibm.com>
Mon, 11 Feb 2019 10:06:27 +0000 (11:06 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 5 Apr 2019 20:33:07 +0000 (22:33 +0200)
[ Upstream commit 2187d87eacd46f6214ce3dc9cfd7a558375a4153 ]

On IBM z13 machine types 2964 and 2965 the descriptor
sizes for sampling and diagnostic sampling entries
might be missing in the trailer entry and are set to zero.

This leads to a perf report failure when processing diagnostic
sampling entries.

This patch adds missing descriptor sizes when the trailer entry
contains zero for these fields.

Output before:
  [root@s38lp82 perf]#  ./perf report --stdio | fgrep Samples
  0xabbf0 [0x8]: failed to process type: 68
  Error:
  failed to process sample
  [root@s38lp82 perf]#

Output after:
  [root@s38lp82 perf]#  ./perf report --stdio | fgrep Samples
  # Total Lost Samples: 0
  # Samples: 3K of event 'SF_CYCLES_BASIC_DIAG'
  # Samples: 162  of event 'CF_DIAG'
  [root@s38lp82 perf]#

Fixes: 2b1444f2e28b ("perf report: Add raw report support for s390 auxiliary trace")
Signed-off-by: Thomas Richter <tmricht@linux.ibm.com>
Reviewed-by: Hendrik Brueckner <brueckner@linux.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Link: http://lkml.kernel.org/r/20190211100627.85714-1-tmricht@linux.ibm.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/perf/util/s390-cpumsf.c

index aa7f8c11fbb7db9fe815f07cdd3a750d242a6d57..910f2621d21122eeaa435fc327c442b214b33c5d 100644 (file)
@@ -294,6 +294,11 @@ static bool s390_cpumsf_validate(int machine_type,
                        *dsdes = 85;
                        *bsdes = 32;
                        break;
+               case 2964:
+               case 2965:
+                       *dsdes = 112;
+                       *bsdes = 32;
+                       break;
                default:
                        /* Illegal trailer entry */
                        return false;