]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
crypto: spacc - Fix off by one in spacc_isenabled()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 14 Aug 2024 21:11:58 +0000 (00:11 +0300)
committerHerbert Xu <herbert@gondor.apana.org.au>
Sat, 24 Aug 2024 13:36:07 +0000 (21:36 +0800)
The spacc->config.modes[] array has CRYPTO_MODE_LAST number of elements
so this > comparison should be >= to prevent an out of bounds access.

Fixes: c8981d9230d8 ("crypto: spacc - Add SPAcc Skcipher support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/dwc-spacc/spacc_core.c

index e3380528e82b88806e5f73e32a15deda2154f0ce..b7630f559973b6c24e927a0f37fb8bc8485801de 100644 (file)
@@ -1295,7 +1295,7 @@ int spacc_isenabled(struct spacc_device *spacc, int mode, int keysize)
 {
        int x;
 
-       if (mode < 0 || mode > CRYPTO_MODE_LAST)
+       if (mode < 0 || mode >= CRYPTO_MODE_LAST)
                return 0;
 
        if (mode == CRYPTO_MODE_NULL    ||