]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
cxgb4: Fix decode strings dump for T6 adapters
authorGleb Markov <markov.gi@npc-ksb.ru>
Mon, 29 Jun 2026 13:08:54 +0000 (16:08 +0300)
committerJakub Kicinski <kuba@kernel.org>
Wed, 1 Jul 2026 00:18:28 +0000 (17:18 -0700)
Depending on the value of chip_version, the correct decode set is selected.
However, the subsequent matching with the t4 encoding type in the if-else
block results in a reassignment, which leads to the loss of support for
t6_decode as well as reinitializing of values t4_decode and t5_decode.

The component history shows that the if-else block previously used for
this purpose, as well as the execution order, was not affected by the
change.
Furthermore, it is suggested by the execution order that the scenario with
overwriting and loss of support will be implemented.

Delete the if-else block.

Fixes: 6df397539cb0 ("cxgb4: Update correct encoding of SGE Ingress DMA States for T6 adapter")
Signed-off-by: Gleb Markov <markov.gi@npc-ksb.ru>
Reviewed-by: Potnuri Bharat Teja <bharat@chelsio.com>
Link: https://patch.msgid.link/20260629130856.1168-1-markov.gi@npc-ksb.ru
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c

index 171750fad44f2eedfc294df0459c06f849641ed0..6871127427fad7f1af84d6fecb2860772142e4b2 100644 (file)
@@ -6737,14 +6737,6 @@ void t4_sge_decode_idma_state(struct adapter *adapter, int state)
                return;
        }
 
-       if (is_t4(adapter->params.chip)) {
-               sge_idma_decode = (const char **)t4_decode;
-               sge_idma_decode_nstates = ARRAY_SIZE(t4_decode);
-       } else {
-               sge_idma_decode = (const char **)t5_decode;
-               sge_idma_decode_nstates = ARRAY_SIZE(t5_decode);
-       }
-
        if (state < sge_idma_decode_nstates)
                CH_WARN(adapter, "idma state %s\n", sge_idma_decode[state]);
        else