]> git.ipfire.org Git - thirdparty/glibc.git/commitdiff
x86: Black list more Intel CPUs for TSX [BZ #27398]
authorH.J. Lu <hjl.tools@gmail.com>
Fri, 14 Jan 2022 22:48:01 +0000 (14:48 -0800)
committerH.J. Lu <hjl.tools@gmail.com>
Tue, 1 Feb 2022 15:38:16 +0000 (07:38 -0800)
Disable TSX and enable RTM_ALWAYS_ABORT for Intel CPUs listed in:

https://www.intel.com/content/www/us/en/support/articles/000059422/processors.html

This fixes BZ #27398.

Reviewed-by: Noah Goldstein <goldstein.w.n@gmail.com>
(cherry picked from commit 1e000d3d33211d5a954300e2a69b90f93f18a1a1)

sysdeps/x86/cpu-features.c

index 1460b6dc3a06114bc0fcfcee22fe92cc4fa8bc21..0f35c654b23db040957eba2561f0240879226be8 100644 (file)
@@ -396,11 +396,42 @@ init_cpu_features (struct cpu_features *cpu_features)
              break;
            }
 
-        /* Disable TSX on some Haswell processors to avoid TSX on kernels that
-           weren't updated with the latest microcode package (which disables
-           broken feature by default).  */
+        /* Disable TSX on some processors to avoid TSX on kernels that
+           weren't updated with the latest microcode package (which
+           disables broken feature by default).  */
         switch (model)
            {
+           case 0x55:
+             if (stepping <= 5)
+               goto disable_tsx;
+             break;
+           case 0x8e:
+             /* NB: Although the errata documents that for model == 0x8e,
+                only 0xb stepping or lower are impacted, the intention of
+                the errata was to disable TSX on all client processors on
+                all steppings.  Include 0xc stepping which is an Intel
+                Core i7-8665U, a client mobile processor.  */
+           case 0x9e:
+             if (stepping > 0xc)
+               break;
+             /* Fall through.  */
+           case 0x4e:
+           case 0x5e:
+             {
+               /* Disable Intel TSX and enable RTM_ALWAYS_ABORT for
+                  processors listed in:
+
+https://www.intel.com/content/www/us/en/support/articles/000059422/processors.html
+                */
+disable_tsx:
+               cpu_features->cpuid[index_cpu_HLE].reg_HLE
+                 &= ~bit_cpu_HLE;
+               cpu_features->cpuid[index_cpu_RTM].reg_RTM
+                 &= ~bit_cpu_RTM;
+               cpu_features->cpuid[index_cpu_RTM_ALWAYS_ABORT].reg_RTM_ALWAYS_ABORT
+                 |= bit_cpu_RTM_ALWAYS_ABORT;
+             }
+             break;
            case 0x3f:
              /* Xeon E7 v3 with stepping >= 4 has working TSX.  */
              if (stepping >= 4)