]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/i915/alpm: Add new interface to check if AUXLess ALPM is used
authorJouni Högander <jouni.hogander@intel.com>
Mon, 26 May 2025 12:05:07 +0000 (15:05 +0300)
committerJouni Högander <jouni.hogander@intel.com>
Thu, 29 May 2025 05:13:41 +0000 (08:13 +0300)
we need to know if AUXLess ALPM is used when preparing for link
training. Add new interface for this and use it in existing code where
possible.

v2: remove kerneldoc comment

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Link: https://lore.kernel.org/r/20250526120512.1702815-8-jouni.hogander@intel.com
drivers/gpu/drm/i915/display/intel_alpm.c
drivers/gpu/drm/i915/display/intel_alpm.h

index 0890247085a7a6897c465266d1e94215e3f90fd1..bbcf510b0c254afabeb616c8698b7492c8a3b7e1 100644 (file)
@@ -26,6 +26,13 @@ bool intel_alpm_aux_less_wake_supported(struct intel_dp *intel_dp)
        return intel_dp->alpm_dpcd & DP_ALPM_AUX_LESS_CAP;
 }
 
+bool intel_alpm_is_alpm_aux_less(struct intel_dp *intel_dp,
+                                const struct intel_crtc_state *crtc_state)
+{
+       return intel_psr_needs_alpm_aux_less(intel_dp, crtc_state) ||
+               (crtc_state->has_lobf && intel_alpm_aux_less_wake_supported(intel_dp));
+}
+
 void intel_alpm_init(struct intel_dp *intel_dp)
 {
        u8 dpcd;
@@ -341,8 +348,7 @@ static void lnl_alpm_configure(struct intel_dp *intel_dp,
         * Panel Replay on eDP is always using ALPM aux less. I.e. no need to
         * check panel support at this point.
         */
-       if ((crtc_state->has_panel_replay && intel_dp_is_edp(intel_dp)) ||
-           (crtc_state->has_lobf && intel_alpm_aux_less_wake_supported(intel_dp))) {
+       if (intel_alpm_is_alpm_aux_less(intel_dp, crtc_state)) {
                alpm_ctl = ALPM_CTL_ALPM_ENABLE |
                        ALPM_CTL_ALPM_AUX_LESS_ENABLE |
                        ALPM_CTL_AUX_LESS_SLEEP_HOLD_TIME_50_SYMBOLS |
index c9fe21e3e72cee3561eccb30fab8f676161dbdd9..86f4d5ab1981b0f6ef92962cc55d64775be0a764 100644 (file)
@@ -32,6 +32,8 @@ void intel_alpm_post_plane_update(struct intel_atomic_state *state,
 void intel_alpm_lobf_debugfs_add(struct intel_connector *connector);
 bool intel_alpm_aux_wake_supported(struct intel_dp *intel_dp);
 bool intel_alpm_aux_less_wake_supported(struct intel_dp *intel_dp);
+bool intel_alpm_is_alpm_aux_less(struct intel_dp *intel_dp,
+                                const struct intel_crtc_state *crtc_state);
 void intel_alpm_disable(struct intel_dp *intel_dp);
 bool intel_alpm_get_error(struct intel_dp *intel_dp);
 #endif