bnxt_en: Update MRU and RSS table of RSS contexts on queue reset

The commit under the Fixes tag below which updates the VNICs' RSS
and MRU during .ndo_queue_start(), needs to be extended to cover any
non-default RSS contexts which have their own VNICs.  Without this
step, packets that are destined to a non-default RSS context may be
dropped after .ndo_queue_start().

We further optimize this scheme by updating the VNIC only if the
RX ring being restarted is in the RSS table of the VNIC.  Updating
the VNIC (in particular setting the MRU to 0) will momentarily stop
all traffic to all rings in the RSS table.  Any VNIC that has the
RX ring excluded from the RSS table can skip this step and avoid the
traffic disruption.

Note that this scheme is just an improvement.  A VNIC with multiple
rings in the RSS table will still see traffic disruptions to all rings
in the RSS table when one of the rings is being restarted.  We are
working on a FW scheme that will improve upon this further.

Fixes: 5ac066b7b062 ("bnxt_en: Fix queue start to update vnic RSS table")
Reported-by: David Wei <dw@davidwei.uk>
Signed-off-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Link: https://patch.msgid.link/20250613231841.377988-4-michael.chan@broadcom.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index dfd2366d4c8ca5ae1fd0e3f8360e86377c8342bd..2cb3185c442c459e180ffda962abec6feac3f4b4 100644 (file)
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -10780,11 +10780,39 @@ void bnxt_del_one_rss_ctx(struct bnxt *bp, struct bnxt_rss_ctx *rss_ctx,
        bp->num_rss_ctx--;
 }
 
+static bool bnxt_vnic_has_rx_ring(struct bnxt *bp, struct bnxt_vnic_info *vnic,
+                                 int rxr_id)
+{
+       u16 tbl_size = bnxt_get_rxfh_indir_size(bp->dev);
+       int i, vnic_rx;
+
+       /* Ntuple VNIC always has all the rx rings. Any change of ring id
+        * must be updated because a future filter may use it.
+        */
+       if (vnic->flags & BNXT_VNIC_NTUPLE_FLAG)
+               return true;
+
+       for (i = 0; i < tbl_size; i++) {
+               if (vnic->flags & BNXT_VNIC_RSSCTX_FLAG)
+                       vnic_rx = ethtool_rxfh_context_indir(vnic->rss_ctx)[i];
+               else
+                       vnic_rx = bp->rss_indir_tbl[i];
+
+               if (rxr_id == vnic_rx)
+                       return true;
+       }
+
+       return false;
+}
+
 static int bnxt_set_vnic_mru_p5(struct bnxt *bp, struct bnxt_vnic_info *vnic,
-                               u16 mru)
+                               u16 mru, int rxr_id)
 {
        int rc;
 
+       if (!bnxt_vnic_has_rx_ring(bp, vnic, rxr_id))
+               return 0;
+
        if (mru) {
                rc = bnxt_hwrm_vnic_set_rss_p5(bp, vnic, true);
                if (rc) {
@@ -10800,6 +10828,24 @@ static int bnxt_set_vnic_mru_p5(struct bnxt *bp, struct bnxt_vnic_info *vnic,
        return 0;
 }
 
+static int bnxt_set_rss_ctx_vnic_mru(struct bnxt *bp, u16 mru, int rxr_id)
+{
+       struct ethtool_rxfh_context *ctx;
+       unsigned long context;
+       int rc;
+
+       xa_for_each(&bp->dev->ethtool->rss_ctx, context, ctx) {
+               struct bnxt_rss_ctx *rss_ctx = ethtool_rxfh_context_priv(ctx);
+               struct bnxt_vnic_info *vnic = &rss_ctx->vnic;
+
+               rc = bnxt_set_vnic_mru_p5(bp, vnic, mru, rxr_id);
+               if (rc)
+                       return rc;
+       }
+
+       return 0;
+}
+
 static void bnxt_hwrm_realloc_rss_ctx_vnic(struct bnxt *bp)
 {
        bool set_tpa = !!(bp->flags & BNXT_FLAG_TPA);
@@ -16002,12 +16048,11 @@ static int bnxt_queue_start(struct net_device *dev, void *qmem, int idx)
        for (i = 0; i < bp->nr_vnics; i++) {
                vnic = &bp->vnic_info[i];
 
-               rc = bnxt_set_vnic_mru_p5(bp, vnic, mru);
+               rc = bnxt_set_vnic_mru_p5(bp, vnic, mru, idx);
                if (rc)
                        return rc;
        }
-
-       return 0;
+       return bnxt_set_rss_ctx_vnic_mru(bp, mru, idx);
 
 err_reset:
        netdev_err(bp->dev, "Unexpected HWRM error during queue start rc: %d\n",
@@ -16030,8 +16075,9 @@ static int bnxt_queue_stop(struct net_device *dev, void *qmem, int idx)
        for (i = 0; i < bp->nr_vnics; i++) {
                vnic = &bp->vnic_info[i];
 
-               bnxt_set_vnic_mru_p5(bp, vnic, 0);
+               bnxt_set_vnic_mru_p5(bp, vnic, 0, idx);
        }
+       bnxt_set_rss_ctx_vnic_mru(bp, 0, idx);
        /* Make sure NAPI sees that the VNIC is disabled */
        synchronize_net();
        rxr = &bp->rx_ring[idx];