Remove an ALWAYS() that can be false in some very rare cases.

dbsqlfuzz 2274a23c85a93b870f7eb12fe686073da01abc33

FossilOrigin-Name: a4eb0b0d837291590958a5f292f41e80e0f722668a060aebfed5ea36ea176332

diff --git a/manifest b/manifest
index 669b7f9aabb2e77bad78bc409ff012aad6140a5c..c631de64e7a8d8b99865bed91da8c18be471027e 100644 (file)
--- a/manifest
+++ b/manifest
@@ -1,5 +1,5 @@
-C Updates\sto\sthe\stestrunner.tcl\sscript\sso\sthat\suses\sa\sseparate\ssub-process\sfor\seach\stest.\sAnd\sso\sthat\sit\sruns\sthe\srelease\stest\sprocedure\scurrently\shandled\sby\swapptest.tcl.
-D 2023-02-04T19:01:17.591
+C Remove\san\sALWAYS()\sthat\scan\sbe\sfalse\sin\ssome\svery\srare\scases.\ndbsqlfuzz\s2274a23c85a93b870f7eb12fe686073da01abc33
+D 2023-02-04T20:07:52.995
 F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
 F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
 F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@ -608,7 +608,7 @@ F src/os_setup.h 6011ad7af5db4e05155f385eb3a9b4470688de6f65d6166b8956e58a3d87210
 F src/os_unix.c 49b0d3d0f86fc4736d1b9a71035bbd791b892ed6908803f270d4d71f149c60ac
 F src/os_win.c 295fe45f18bd86f2477f4cd79f3377c6f883ceb941b1f46808665c73747f2345
 F src/os_win.h 7b073010f1451abe501be30d12f6bc599824944a
-F src/pager.c a70ebfdca54fce32ba748087f2fc8739af479222590148dfa17d4ad71bcf8ff2
+F src/pager.c 7d1e34befba172b7f84b53c0c714e06661b22742312ad2fbb0a3bbd2d5d4f939
 F src/pager.h f82e9844166e1585f5786837ddc7709966138ced17f568c16af7ccf946c2baa3
 F src/parse.y 8e67d820030d2655b9942ffe61c1e7e6b96cea2f2f72183533299393907d0564
 F src/pcache.c f4268f7f73c6a3db12ce22fd25bc68dc42315d19599414ab1207d7cf32f79197
@@ -2048,9 +2048,8 @@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a91a7acc6293828957a386a8a93
 F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
 F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
 F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
-P a98e4908dabc8f45f7859a26bd1d0c04de34ec68c1367c2cdd9b0242e08b938f 7624de3a93e03e9e825b1a283ccde8ad3aa41f93dd5c7f63692620a5177cbda9
-R b23b921e204f6eaaf5ec2663c7720a91
-T +closed 7624de3a93e03e9e825b1a283ccde8ad3aa41f93dd5c7f63692620a5177cbda9
-U dan
-Z 92f5ffe758031c7babad159f1502cbcd
+P 4c3c587500ac5a3758008f0acb9432bd3bc6f0f31bacd5615f46280e55842982
+R 8cf815638e386ddde1401eb009f5d3e4
+U drh
+Z 221a67f438dc59c58979db2b65b9ccb0
 # Remove this line to create a well-formed Fossil manifest.

diff --git a/manifest.uuid b/manifest.uuid
index 762494202255557736fb0d725f075d4bebf39eac..114a6eee5acecd249cbe55a49e0f5cd8d6fc06bf 100644 (file)
--- a/manifest.uuid
+++ b/manifest.uuid
@@ -1 +1 @@
-4c3c587500ac5a3758008f0acb9432bd3bc6f0f31bacd5615f46280e55842982
\ No newline at end of file
+a4eb0b0d837291590958a5f292f41e80e0f722668a060aebfed5ea36ea176332
\ No newline at end of file

diff --git a/src/pager.c b/src/pager.c
index 8517ab4b3fde66d2ef1c2edb1667e475e5faeaa4..5f6e975fd858ac680f9974d803388ac9fbf27b25 100644 (file)
--- a/src/pager.c
+++ b/src/pager.c
@@ -6267,7 +6267,7 @@ static int pager_incr_changecounter(Pager *pPager, int isDirectMode){
 # define DIRECT_MODE isDirectMode
 #endif
 
-  if( !pPager->changeCountDone && ALWAYS(pPager->dbSize>0) ){
+  if( !pPager->changeCountDone && pPager->dbSize>0 ){
     PgHdr *pPgHdr;                /* Reference to page 1 */
 
     assert( !pPager->tempFile && isOpen(pPager->fd) );