]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
exec: Fix incorrect type for ret
authorXichao Zhao <zhao.xichao@vivo.com>
Mon, 25 Aug 2025 07:36:09 +0000 (15:36 +0800)
committerKees Cook <kees@kernel.org>
Mon, 25 Aug 2025 16:33:33 +0000 (09:33 -0700)
In the setup_arg_pages(), ret is declared as an unsigned long.
The ret might take a negative value. Therefore, its type should
be changed to int.

Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20250825073609.219855-1-zhao.xichao@vivo.com
Signed-off-by: Kees Cook <kees@kernel.org>
fs/exec.c

index 2a1e5e4042a14940fe749207361abb25130df3d4..5d236bb87df5f6b8c23af6c613907ef1e4fd84f1 100644 (file)
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -599,7 +599,7 @@ int setup_arg_pages(struct linux_binprm *bprm,
                    unsigned long stack_top,
                    int executable_stack)
 {
-       unsigned long ret;
+       int ret;
        unsigned long stack_shift;
        struct mm_struct *mm = current->mm;
        struct vm_area_struct *vma = bprm->vma;