]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
CLEANUP: http_ana: remove unused assignation of `att_beg`
authorWilliam Dauchy <wdauchy@gmail.com>
Sun, 25 Oct 2020 13:01:33 +0000 (14:01 +0100)
committerChristopher Faulet <cfaulet@haproxy.com>
Mon, 26 Oct 2020 14:00:09 +0000 (15:00 +0100)
`att_beg` is assigned to `next` at the end of the `for` loop, but is
assigned to `prev` at the beginning of the loop, which is itself
assigned to `next` after each loop. So it represents a double
assignation for the same value. Also `att_beg` is not used after the end
of the loop.

this is a partial fix for github issue #923, all the others could
probably be marked as intentional to protect future changes.

no backport needed.

Signed-off-by: William Dauchy <wdauchy@gmail.com>
src/http_ana.c

index f2edc681f9b7791bba766576b93b520a7237b7ac..c2080bf9a7a8cb045a83085341f4f803c7783871 100644 (file)
@@ -3533,8 +3533,6 @@ static void http_manage_client_side_cookies(struct stream *s, struct channel *re
                                }
                        }
 
-                       /* continue with next cookie on this header line */
-                       att_beg = next;
                } /* for each cookie */