[#3833] addressed review comments

diff --git a/doc/sphinx/arm/agent.rst b/doc/sphinx/arm/agent.rst
index 4f3619656594d275f837a21b96d38db2dc9b11a7..b6c58e026579a0587d45a203795f500b18ad15cb 100644 (file)
--- a/doc/sphinx/arm/agent.rst
+++ b/doc/sphinx/arm/agent.rst
@@ -154,7 +154,7 @@ specified for the DHCPv4, DHCPv6, and D2 services.
 
     As of Kea 2.7.9, control sockets may only reside in the directory
     determined during compilation as ``"[kea-install-dir]/var/run/kea"``,
-    which must also have ``750`` access rights. This path may be overridden
+    which must also have ``0750`` access rights. This path may be overridden
     at startup by setting the environment variable ``KEA_CONTROL_SOCKET_DIR``
     to the desired path.  If a path other than this value is used in
     ``socket-name``, Kea will emit an error and refuse to start or, if already

diff --git a/doc/sphinx/arm/ddns.rst b/doc/sphinx/arm/ddns.rst
index d3077096a9657c19bb67f5c05fff45d57fa7fc90..384a2dd44ac791f9d3d92570446c781c1ff5d2c2 100644 (file)
--- a/doc/sphinx/arm/ddns.rst
+++ b/doc/sphinx/arm/ddns.rst
@@ -328,7 +328,7 @@ Kea supports only one ``unix`` control socket in the "control-sockets" list.
 
     As of Kea 2.7.9, control sockets may only reside in the directory
     determined during compilation as ``"[kea-install-dir]/var/run/kea"``,
-    which must also have ``750`` access rights. This path may be overridden
+    which must also have ``0750`` access rights. This path may be overridden
     at startup by setting the environment variable ``KEA_CONTROL_SOCKET_DIR``
     to the desired path.  If a path other than this value is used in
     ``socket-name``, Kea will emit an error and refuse to start or, if already

diff --git a/doc/sphinx/arm/dhcp4-srv.rst b/doc/sphinx/arm/dhcp4-srv.rst
index 72624b4526f6e2573a75178df0bd7a2359a55864..d6ff2b3edd71fe574673919edc1c77f40c5a2fd6 100644 (file)
--- a/doc/sphinx/arm/dhcp4-srv.rst
+++ b/doc/sphinx/arm/dhcp4-srv.rst
@@ -7840,7 +7840,7 @@ Kea supports only one ``unix`` control socket in the "control-sockets" list.
 
     As of Kea 2.7.9, control sockets may only reside in the directory
     determined during compilation as ``"[kea-install-dir]/var/run/kea"``,
-    which must also have ``750`` access rights. This path may be overridden
+    which must also have ``0750`` access rights. This path may be overridden
     at startup by setting the environment variable ``KEA_CONTROL_SOCKET_DIR``
     to the desired path.  If a path other than this value is used in
     ``socket-name``, Kea will emit an error and refuse to start or, if already

diff --git a/doc/sphinx/arm/dhcp6-srv.rst b/doc/sphinx/arm/dhcp6-srv.rst
index 43fb3084533ad5260dd91feab42542ccc85ada2a..b2a89d0529d981870db32d5c619e4a9648ac8359 100644 (file)
--- a/doc/sphinx/arm/dhcp6-srv.rst
+++ b/doc/sphinx/arm/dhcp6-srv.rst
@@ -7746,7 +7746,7 @@ Kea supports only one ``unix`` control socket in the "control-sockets" list.
 
     As of Kea 2.7.9, control sockets may only reside in the directory
     determined during compilation as ``"[kea-install-dir]/var/run/kea"``,
-    which must also have ``750`` access rights. This path may be overridden
+    which must also have ``0750`` access rights. This path may be overridden
     at startup by setting the environment variable ``KEA_CONTROL_SOCKET_DIR``
     to the desired path.  If a path other than this value is used in
     ``socket-name``, Kea will emit an error and refuse to start or, if already

diff --git a/doc/sphinx/arm/security.rst b/doc/sphinx/arm/security.rst
index 75786a04a209491c88088760470254c621b74446..6ad9aace3e3189a67e0089899de7dd5783f207c4 100644 (file)
--- a/doc/sphinx/arm/security.rst
+++ b/doc/sphinx/arm/security.rst
@@ -39,8 +39,9 @@ protection possible:
 .. note::
 
    It is recommend to use privileged ports for HTTP/HTTPS against local attacks
-   (users which are conencted to the box where Kea servers/agents run). This measure
-   also prevents against impersonation with HTTP and DoS in general.
+   (by users which are connected to the box where Kea servers/agents run). This
+   measure also prevents against impersonation with HTTP and Denial of Service in
+   general.
 
 .. note::
 
@@ -328,7 +329,7 @@ file-access control on POSIX systems (owner, group, others, read/write).
 
     As of Kea 2.7.9, control sockets may only reside in the directory
     determined during compilation as ``"[kea-install-dir]/var/run/kea"``,
-    which must also have ``750`` access rights. This path may be overridden
+    which must also have ``0750`` access rights. This path may be overridden
     at startup by setting the environment variable ``KEA_CONTROL_SOCKET_DIR``
     to the desired path.  If a path other than this value is used in
     ``socket-name``, Kea will emit an error and refuse to start or, if already
@@ -500,8 +501,8 @@ using basic HTTP authentication.
 
 Kea 1.9.2 introduced a new ``auth`` hook point. With this new hook point, it is possible to develop an external
 hook library to extend the access controls, integrate with another authentication authority, or add role-based
-access control to the Control Agent. This hookpoint is also supported by the DHCP and DDNS servers since Kea
-version 2.7.2.
+access control to the Control Agent. This hookpoint was renamed as ``http_auth`` and is also supported by the DHCP
+and DDNS servers since Kea version 2.7.2.
 
 .. note:
 

diff --git a/src/lib/util/filesystem.cc b/src/lib/util/filesystem.cc
index dc90bbf1d11abef336583ab17565d3cb41c3e2da..fd65e7bcb58b117edb147ed8be8d796f2783b7a4 100644 (file)
--- a/src/lib/util/filesystem.cc
+++ b/src/lib/util/filesystem.cc
@@ -10,7 +10,6 @@
 #include <util/filesystem.h>
 #include <util/str.h>
 
-#include <sys/stat.h>
 #include <cstdio>
 #include <cstdlib>
 #include <fstream>

diff --git a/src/lib/util/filesystem.h b/src/lib/util/filesystem.h
index 09e953599cbe2eb77ca5bddd412a96da622ec8d6..8147d8c5b708525ce63816e8df4ab313b3850651 100644 (file)
--- a/src/lib/util/filesystem.h
+++ b/src/lib/util/filesystem.h
@@ -7,7 +7,7 @@
 #ifndef KEA_UTIL_FILESYSTEM_H
 #define KEA_UTIL_FILESYSTEM_H
 
-#include <sys/types.h>
+#include <sys/stat.h>
 #include <string>
 #include <boost/shared_ptr.hpp>