]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
xfs_db: remove unnessary checks in process_leaf_node_dir_v2_free
authorVivek Trivedi <t.vivek@samsung.com>
Sun, 20 Dec 2015 23:54:39 +0000 (10:54 +1100)
committerDave Chinner <david@fromorbit.com>
Sun, 20 Dec 2015 23:54:39 +0000 (10:54 +1100)
xfs_dir2_free_hdr_t entries are unsigned, so they can't be negative.
remove these unnessary checks in process_leaf_node_dir_v2_free.
Reported by coverity.

Signed-off-by: Vivek Trivedi <t.vivek@samsung.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
db/check.c

index f1620f863f2f30dbe1e38421a35d05f51c49104e..341a83c4c054dd0dc170b19c337828b717b29984 100644 (file)
@@ -3073,9 +3073,7 @@ process_leaf_node_dir_v3_free(
                return;
        }
        if (be32_to_cpu(free->hdr.nvalid) > maxent || 
-                               be32_to_cpu(free->hdr.nvalid) < 0 ||
                                be32_to_cpu(free->hdr.nused) > maxent || 
-                               be32_to_cpu(free->hdr.nused) < 0 ||
                                be32_to_cpu(free->hdr.nused) > 
                                        be32_to_cpu(free->hdr.nvalid)) {
                if (!sflag || v)