lib/gshadow.c: fgetsgent(): Don't use static variables

BTW, getline(3) says we are responsible for free(3)ing the buffer on
error.

Reported-by: Chris Hofstaedtler <zeha@debian.org>
Signed-off-by: Alejandro Colomar <alx@kernel.org>

diff --git a/lib/shadow/gshadow/fgetsgent.c b/lib/shadow/gshadow/fgetsgent.c
index 56345d5eaa7aa2d2ca528bc774e50d30955dd068..0af9c6015fb40625d706a2a88dd21018cc4fc46e 100644 (file)
--- a/lib/shadow/gshadow/fgetsgent.c
+++ b/lib/shadow/gshadow/fgetsgent.c
@@ -34,18 +34,27 @@
 struct sgrp *
 fgetsgent(FILE *fp)
 {
-       static size_t buflen = 0;
-       static char *buf = NULL;
+       char         *buf;
+       size_t       buflen;
+       struct sgrp  *sg;
 
        if (NULL == fp) {
                return NULL;
        }
 
+       buf = NULL;
+       buflen = 0;
        if (getline(&buf, &buflen, fp) == -1)
-               return NULL;
+               goto fail;
        if (stpsep(buf, "\n") == NULL)
-               return NULL;
+               goto fail;
+
+       sg = sgetsgent(buf);
 
-       return sgetsgent(buf);
+       free(buf);
+       return sg;
+fail:
+       free(buf);
+       return NULL;
 }
 #endif