]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
perf ui browser map: Provide feedback on unhandled hotkeys
authorArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 8 Apr 2025 20:57:25 +0000 (17:57 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 10 Apr 2025 13:46:26 +0000 (10:46 -0300)
Don't just eat unknown keys without providing visual feedback and
instructions on how to see which ones are assigned.

Suggested-by: Ingo Molnar <mingo@kernel.org>
Tested-by: Ingo Molnar <mingo@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: James Clark <james.clark@linaro.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: https://lore.kernel.org/r/Z_TYux5fUg2pW-pF@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/ui/browsers/map.c

index fba55175a93593173623b8cf9afe420c064ca0ae..c61ba3174a240fa8199b2a4149fda53543be3ae6 100644 (file)
@@ -88,8 +88,10 @@ static int map_browser__run(struct map_browser *browser)
                case '/':
                        if (verbose > 0)
                                map_browser__search(browser);
+                       /* fall thru */
                default:
-                       break;
+                       ui_browser__warn_unhandled_hotkey(&browser->b, key, 0, NULL);
+                       continue;
                 case K_LEFT:
                 case K_ESC:
                 case 'q':