]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: ipu-bridge: Use %pe format specifier
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 13 Oct 2025 14:15:01 +0000 (14:15 +0000)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Fri, 17 Oct 2025 09:31:15 +0000 (11:31 +0200)
The %pe format specifier is designed to print error pointers. It prints
a symbolic error name (eg. -EINVAL) and it makes the code simpler by
omitting PTR_ERR().

This patch fixes this cocci report:
./pci/intel/ipu-bridge.c:567:3-10: WARNING: Consider using %pe to print PTR_ERR()

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/pci/intel/ipu-bridge.c

index 4e579352ab2c0be656576fa223429432940747d8..153b2f3685b447130b7ddfc2f971ffca8acd68aa 100644 (file)
@@ -563,8 +563,8 @@ static void ipu_bridge_instantiate_vcm_work(struct work_struct *work)
        vcm_client = i2c_acpi_new_device_by_fwnode(acpi_fwnode_handle(adev),
                                                   1, &data->board_info);
        if (IS_ERR(vcm_client)) {
-               dev_err(data->sensor, "Error instantiating VCM client: %ld\n",
-                       PTR_ERR(vcm_client));
+               dev_err(data->sensor, "Error instantiating VCM client: %pe\n",
+                       vcm_client);
                goto out_pm_put;
        }