]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
memory: ti-aemif: simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 16 Aug 2024 10:54:37 +0000 (12:54 +0200)
committerKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Wed, 21 Aug 2024 11:41:00 +0000 (13:41 +0200)
Use scoped for_each_available_child_of_node_scoped() when iterating over
device nodes to make code a bit simpler.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20240816-cleanup-h-of-node-put-memory-v2-13-9eed0ee16b78@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
drivers/memory/ti-aemif.c

index a1f1922ea291246a0bb4484f978cf00b735f0265..3b546eddf5fe9267185a01f009e5511ea639eb07 100644 (file)
@@ -329,7 +329,6 @@ static int aemif_probe(struct platform_device *pdev)
        int ret = -ENODEV;
        struct device *dev = &pdev->dev;
        struct device_node *np = dev->of_node;
-       struct device_node *child_np;
        struct aemif_device *aemif;
 
        aemif = devm_kzalloc(dev, sizeof(*aemif), GFP_KERNEL);
@@ -359,12 +358,10 @@ static int aemif_probe(struct platform_device *pdev)
                 * functions iterate over these nodes and update the cs data
                 * array.
                 */
-               for_each_available_child_of_node(np, child_np) {
+               for_each_available_child_of_node_scoped(np, child_np) {
                        ret = of_aemif_parse_abus_config(pdev, child_np);
-                       if (ret < 0) {
-                               of_node_put(child_np);
+                       if (ret < 0)
                                return ret;
-                       }
                }
        }