]> git.ipfire.org Git - thirdparty/foundation/foundation-sites.git/commitdiff
Merge pull request #11829 from DanielRuf/refactor/format-mark-unused
authorJoe Workman <joe@workmanmail.com>
Mon, 3 Feb 2020 18:50:40 +0000 (10:50 -0800)
committerGitHub <noreply@github.com>
Mon, 3 Feb 2020 18:50:40 +0000 (10:50 -0800)
refactor: reformat code and mark unused parameters

1  2 
docs/assets/img/gulpfile.js
js/foundation.core.js
js/foundation.core.utils.js
js/foundation.responsiveAccordionTabs.js

Simple merge
index 2a6fb099f942fb052178995c5246329dc420da88,3308529508cfa22c464abf12512862841f3a7b04..a0707889e6833b9d8cc2b4d7c374812fa220a5ad
@@@ -156,11 -156,11 +156,11 @@@ var Foundation = 
        // For each plugin found, initialize it
        $elem.each(function() {
          var $el = $(this),
 -            opts = {};
 -            
 +            opts = { reflow: true };
 +
          if($el.attr('data-options')){
-           var thing = $el.attr('data-options').split(';').forEach(function(e, i){
-             var opt = e.split(':').map(function(el){ return el.trim(); });
+           $el.attr('data-options').split(';').forEach(function(option, _index){
+             var opt = option.split(':').map(function(el){ return el.trim(); });
              if(opt[0]) opts[opt[0]] = parseValue(opt[1]);
            });
          }
index b6e7ed8b51077ddfbe0bb2f80983ec3e68a7e8b9,2a10f5675e42c39b155d1ff2a7418a8696648c77..cb7013b30bfabe4b5a89b57d91bd2a7956d2f748
@@@ -51,12 -46,12 +51,12 @@@ function transitionend($elem)
    var elem = document.createElement('div'),
        end;
  
 -  for (var t in transitions){
 -    if (typeof elem.style[t] !== 'undefined'){
 -      end = transitions[t];
 +  for (let transition in transitions){
 +    if (typeof elem.style[transition] !== 'undefined'){
 +      end = transitions[transition];
      }
    }
-   if(end){
+   if (end) {
      return end;
    }else{
      end = setTimeout(function(){
index 81cf7faeb583e7c4126bdccb0977d53860a81a52,5a0fa0841ebe265fe355d65f46c698c839e66ae4..605dc3d8ec952987883bd8bfbdf42f94429bc0c5
@@@ -196,9 -190,9 +196,9 @@@ class ResponsiveAccordionTabs extends P
      if (fromString === 'tabs') {
        $panels = $panels.children('.'+tabsPanel).removeClass(tabsPanel).removeAttr('role').removeAttr('aria-hidden').removeAttr('aria-labelledby');
        $panels.children('a').removeAttr('role').removeAttr('aria-controls').removeAttr('aria-selected');
-     }else{
+     } else {
        $panels = $liHeads.children('[data-tab-content]').removeClass('accordion-content');
 -    };
 +    }
  
      $panels.css({display:'',visibility:''});
      $liHeads.css({display:'',visibility:''});
        if ($placeholder.length) {
          $tabsContent = $('<div class="tabs-content"></div>').insertAfter($placeholder).attr('data-tabs-content',_this.$element.attr('id'));
          $placeholder.remove();
-       }else{
+       } else {
          $tabsContent = $('<div class="tabs-content"></div>').insertAfter(_this.$element).attr('data-tabs-content',_this.$element.attr('id'));
 -      };
 +      }
        $panels.each(function(key,value){
          var tempValue = $(value).appendTo($tabsContent).addClass(tabsPanel);
          var hash = $liHeadsA.get(key).hash.slice(1);