qspawn: drop redundant check against limiter->{max}

We only need to guard against excessive parallelism on entry
in one place during Qspawn->start.  Redundant guards are
confusing and make bugs harder-to-spot.

diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm
index 9bd225b78378d6a71e0a329780d96a0cf9b54c8b..34e9eff69c7862c8041a62a02d7dc4572041f5e9 100644 (file)
--- a/lib/PublicInbox/Qspawn.pm
+++ b/lib/PublicInbox/Qspawn.pm
@@ -107,13 +107,9 @@ sub finalize ($) {
 
        # process is done, spawn whatever's in the queue
        my $limiter = delete $self->{limiter} or return;
-       my $running = --$limiter->{running};
-
-       if ($running < $limiter->{max}) {
-               if (my $next = shift(@{$limiter->{run_queue}})) {
-                       _do_spawn(@$next, $limiter);
-               }
-       }
+       --$limiter->{running};
+       my $next = shift @{$limiter->{run_queue}};
+       _do_spawn(@$next, $limiter) if $next;
        _finalize $self;
 }