]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
irqchip/renesas-rzv2h: Use devm_pm_runtime_enable()
authorBiju Das <biju.das.jz@bp.renesas.com>
Mon, 24 Feb 2025 13:11:22 +0000 (13:11 +0000)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 26 Feb 2025 10:59:50 +0000 (11:59 +0100)
Simplify rzv2h_icu_init() by using devm_pm_runtime_enable().

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/all/20250224131253.134199-7-biju.das.jz@bp.renesas.com
drivers/irqchip/irq-renesas-rzv2h.c

index edae54f9f5da57b59f0cc295378d397eb4957248..10b9b63a1f0920f5f108cafcf1875a3f6d02639c 100644 (file)
@@ -468,11 +468,16 @@ static int rzv2h_icu_init(struct device_node *node, struct device_node *parent)
                return ret;
        }
 
-       pm_runtime_enable(&pdev->dev);
+       ret = devm_pm_runtime_enable(&pdev->dev);
+       if (ret < 0) {
+               dev_err(&pdev->dev, "devm_pm_runtime_enable failed, %d\n", ret);
+               return ret;
+       }
+
        ret = pm_runtime_resume_and_get(&pdev->dev);
        if (ret < 0) {
                dev_err(&pdev->dev, "pm_runtime_resume_and_get failed: %d\n", ret);
-               goto pm_disable;
+               return ret;
        }
 
        raw_spin_lock_init(&rzv2h_icu_data->lock);
@@ -493,8 +498,6 @@ static int rzv2h_icu_init(struct device_node *node, struct device_node *parent)
 
 pm_put:
        pm_runtime_put(&pdev->dev);
-pm_disable:
-       pm_runtime_disable(&pdev->dev);
 
        return ret;
 }