i2c: atr: do not create mapping in detach_addr()

It is useless to create a new mapping just to detach it immediately.

Use the newly added i2c_atr_find_mapping_by_addr() function to avoid it,
and exit without logging an error if not found.

Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

diff --git a/drivers/i2c/i2c-atr.c b/drivers/i2c/i2c-atr.c
index 7e70ac6c0976ee1bbe8a39738bd9e1dbbe14f545..5f08445ce0a352b001072e2ecd9d615d11c06531 100644 (file)
--- a/drivers/i2c/i2c-atr.c
+++ b/drivers/i2c/i2c-atr.c
@@ -586,10 +586,8 @@ static void i2c_atr_detach_addr(struct i2c_adapter *adapter,
 
        mutex_lock(&chan->alias_pairs_lock);
 
-       c2a = i2c_atr_get_mapping_by_addr(chan, addr);
+       c2a = i2c_atr_find_mapping_by_addr(chan, addr);
        if (!c2a) {
-                /* This should never happen */
-               dev_warn(atr->dev, "Unable to find address mapping\n");
                mutex_unlock(&chan->alias_pairs_lock);
                return;
        }