]> git.ipfire.org Git - thirdparty/bootstrap.git/commitdiff
Remove redundant visually hidden "(current)" from pagination controls (#31892)
authorPatrick H. Lauke <redux@splintered.co.uk>
Wed, 14 Oct 2020 10:59:43 +0000 (11:59 +0100)
committerXhmikosR <xhmikosr@gmail.com>
Tue, 27 Oct 2020 10:11:01 +0000 (12:11 +0200)
* Replace visually hidden span with aria-current in tests

* Remove redundant visually hidden "(current)" when `aria-current` already used

Closes #31891

js/tests/visual/dropdown.html
js/tests/visual/modal.html
site/docs/4.5/components/pagination.md

index e8dd3520ded744d40884bd70a59eaaae7bb01176..da1e7d6a35cbf9544a377995ed6c0033fe4ebccd 100644 (file)
@@ -19,7 +19,7 @@
         <div class="collapse navbar-collapse" id="navbarResponsive">
           <ul class="navbar-nav">
             <li class="nav-item active">
-              <a class="nav-link" href="#">Home <span class="sr-only">(current)</span></a>
+              <a class="nav-link" href="#" aria-current="page">Home</a>
             </li>
             <li class="nav-item">
               <a class="nav-link" href="#">Link</a>
index 10a46bb1b770e5c343b273d8853c1f3b10eb4284..85a5f646e69862abf83bdb6af8b23441d82244fc 100644 (file)
@@ -19,7 +19,7 @@
         <a class="navbar-brand" href="#">This shouldn't jump!</a>
         <ul class="navbar-nav">
           <li class="nav-item active">
-            <a class="nav-link" href="#">Home <span class="sr-only">(current)</span></a>
+            <a class="nav-link" href="#" aria-current="page">Home</a>
           </li>
           <li class="nav-item">
             <a class="nav-link" href="#">Link</a>
index b1f8e58a23a19637343b2176564d0553e17c35f7..184a86c234e61194cb5898e3922612a6aa26a022 100644 (file)
@@ -64,7 +64,7 @@ While the `.disabled` class uses `pointer-events: none` to _try_ to disable the
     </li>
     <li class="page-item"><a class="page-link" href="#">1</a></li>
     <li class="page-item active" aria-current="page">
-      <a class="page-link" href="#">2 <span class="sr-only">(current)</span></a>
+      <a class="page-link" href="#">2</a>
     </li>
     <li class="page-item"><a class="page-link" href="#">3</a></li>
     <li class="page-item">
@@ -85,10 +85,7 @@ You can optionally swap out active or disabled anchors for `<span>`, or omit the
     </li>
     <li class="page-item"><a class="page-link" href="#">1</a></li>
     <li class="page-item active" aria-current="page">
-      <span class="page-link">
-        2
-        <span class="sr-only">(current)</span>
-      </span>
+      <span class="page-link">2</span>
     </li>
     <li class="page-item"><a class="page-link" href="#">3</a></li>
     <li class="page-item">
@@ -107,10 +104,7 @@ Fancy larger or smaller pagination? Add `.pagination-lg` or `.pagination-sm` for
 <nav aria-label="...">
   <ul class="pagination pagination-lg">
     <li class="page-item active" aria-current="page">
-      <span class="page-link">
-        1
-        <span class="sr-only">(current)</span>
-      </span>
+      <span class="page-link">1</span>
     </li>
     <li class="page-item"><a class="page-link" href="#">2</a></li>
     <li class="page-item"><a class="page-link" href="#">3</a></li>
@@ -123,10 +117,7 @@ Fancy larger or smaller pagination? Add `.pagination-lg` or `.pagination-sm` for
 <nav aria-label="...">
   <ul class="pagination pagination-sm">
     <li class="page-item active" aria-current="page">
-      <span class="page-link">
-        1
-        <span class="sr-only">(current)</span>
-      </span>
+      <span class="page-link">1</span>
     </li>
     <li class="page-item"><a class="page-link" href="#">2</a></li>
     <li class="page-item"><a class="page-link" href="#">3</a></li>